378745 - Enabling designMode makes images surrounded by text appear selected

Status: NEW

(Core :: DOM: Editor, defect)

Description

[Mathieu Fenniak]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)

When designMode is enabled on an HTML document, some images appear selected automatically.  On Windows, they turn slightly blue.  The images are not actually selected, but just appear that way.  It only occurs on images that are surrounded by non-whitespace on both sides.

A test case will be attached.

Reproducible: Always

Steps to Reproduce:
1. Open test case (to be attached).

Actual Results:  
The first two images on the page appear selected -- they have text surrounding the images.  The second two images on the page are not selected -- the first has a space before the image, and the second has a space after the image.

Expected Results:  
No images should appear selected in the test case.

Comment 1

[Mathieu Fenniak]

Attachment: test case

Comment 2

[Mathieu Fenniak]

Attachment: proposed patch

Tracked this bug down to the inline spell checker.  In the test case, the spell checker would combine the text from both sides of the image ("abc" and "def"), decide that the word "abcdef" is spelled incorrectly, and add the entire range (including the image) to the shell check selection (line 1355 of mozInlineSpellChecker.cpp).  This also explains why the bug does not appear when whitespace is on either side of the image, since the spell checker will not treat the text as a single incorrectly spelled word.

The proposed patch fixes this problem by making an image element, even an inline image, a "break element".  After this patch, the spell checker works on "abc" and "def", but not the combined text.

Comment 3

[Brett Wilson]

Comment on attachment 262775 [details] [diff] [review]
proposed patch

Looks good.

Comment 4

[Peter Van der Beken [:peterv]]

Shouldn't this check for more elements? Applet and object come to mind.

Comment 5

[Jens Stutte [:jstutte]]

Hi Olli, this merits probably a re-triage.