Closed Bug 378958 Opened 13 years ago Closed 13 years ago

Move NSPR pull-tag for 1.8.1.4 and 1.8.0.12

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dveditz, Assigned: nthomas)

References

Details

(Keywords: verified1.8.0.12, verified1.8.1.4)

Attachments

(4 files)

We need to move the NSPR tag to pick up some fixes for the 1.8.1.4 and 1.8.0.12 releases. Not sure what that tag will be yet. Moving the tag will fix bug 363997 and bug 376062 for Firefox (and other clients).
Flags: blocking1.8.1.4+
Flags: blocking1.8.0.12+
Attachment #263058 - Flags: review?(wtc)
Attachment #263059 - Flags: review?(wtc)
Attachment #263058 - Flags: review?(wtc) → review+
The only difference between the two patches is the context. I created two patches to make it easier to apply them.
Attachment #263059 - Flags: review?(wtc) → review+
Comment on attachment 263059 [details] [diff] [review]
Patch for 1.8.0 branch

approved for 1.8.0.12, a=dveditz
Attachment #263059 - Flags: approval1.8.0.12+
Comment on attachment 263058 [details] [diff] [review]
Patch for 1.8 branch

approved for 1.8.1.4, a=dveditz
Attachment #263058 - Flags: approval1.8.1.4+
I took the liberty of checking these two patches in.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Version: Trunk → unspecified
I created the NSPR_4_6_7_RTM tag.  Dan, may I check in this
tag for 1.8.0.12 and 1.8.1.4?
Use the NSPR_4_6_7_RTM tag.  This patch also shows the change
between NSPR_4_6_7_BETA1 and NSPR_4_6_7_RTM (just the version
macros).
Attachment #263763 - Flags: approval1.8.1.4?
This is the corresponding patch for the MOZILLA_1_8_0_BRANCH.
Attachment #263764 - Flags: approval1.8.0.12?
Clearing "fixed" keywords in preparation for landing new patches.
Comment on attachment 263763 [details] [diff] [review]
RTM patch for 1.8 branch

Approved for 1.8.1.4, a=dveditz for release-drivers

The prinit.h isn't supposed to be checked in, it's simply to show us what the tag update does -- right?
Attachment #263763 - Flags: approval1.8.1.4? → approval1.8.1.4+
Comment on attachment 263764 [details] [diff] [review]
RTM patch for 1.8.0 branch

approved for 1.8.0.12, a=dveditz for release-drivers
Attachment #263764 - Flags: approval1.8.0.12? → approval1.8.0.12+
Thank you, Dan.

Yes, the prinit.h change is simply to show you what the
tag update does.

I checked in the patches on the MOZILLA_1_8_BRANCH and
MOZILLA_1_8_0_BRANCH.

Checking in client.mk;
/cvsroot/mozilla/client.mk,v  <--  client.mk
new revision: 1.245.2.37; previous revision: 1.245.2.36
done

Checking in client.mk;
/cvsroot/mozilla/client.mk,v  <--  client.mk
new revision: 1.245.2.6.24.13; previous revision: 1.245.2.6.24.12
done
verified fixed for 1.8.0.12 and 1.8.1.4 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.12) Gecko/20070508 Firefox/1.5.0.12 and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4) Gecko/20070509 Firefox/2.0.0.4 ID:2007050903
Verified in Thunderbird 2.0.0.4rc1, nspr4.dll version in Tbird installation says: 4.6.7.0
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.