378958 - Move NSPR pull-tag for 1.8.1.4 and 1.8.0.12

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Daniel Veditz [:dveditz]]

We need to move the NSPR tag to pick up some fixes for the 1.8.1.4 and 1.8.0.12 releases. Not sure what that tag will be yet. Moving the tag will fix bug 363997 and bug 376062 for Firefox (and other clients).

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch for 1.8 branch

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Patch for 1.8.0 branch

Comment 3

[Kai Engert [:KaiE:]]

The only difference between the two patches is the context. I created two patches to make it easier to apply them.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 263059 [details] [diff] [review]
Patch for 1.8.0 branch

approved for 1.8.0.12, a=dveditz

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 263058 [details] [diff] [review]
Patch for 1.8 branch

approved for 1.8.1.4, a=dveditz

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

I took the liberty of checking these two patches in.

Comment 7

[Wan-Teh Chang]

I created the NSPR_4_6_7_RTM tag.  Dan, may I check in this
tag for 1.8.0.12 and 1.8.1.4?

Comment 8

[Wan-Teh Chang]

Attachment: RTM patch for 1.8 branch

Use the NSPR_4_6_7_RTM tag.  This patch also shows the change
between NSPR_4_6_7_BETA1 and NSPR_4_6_7_RTM (just the version
macros).

Comment 9

[Wan-Teh Chang]

Attachment: RTM patch for 1.8.0 branch

This is the corresponding patch for the MOZILLA_1_8_0_BRANCH.

Comment 10

[Daniel Veditz [:dveditz]]

Clearing "fixed" keywords in preparation for landing new patches.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 263763 [details] [diff] [review]
RTM patch for 1.8 branch

Approved for 1.8.1.4, a=dveditz for release-drivers

The prinit.h isn't supposed to be checked in, it's simply to show us what the tag update does -- right?

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 263764 [details] [diff] [review]
RTM patch for 1.8.0 branch

approved for 1.8.0.12, a=dveditz for release-drivers

Comment 13

[Wan-Teh Chang]

Thank you, Dan.

Yes, the prinit.h change is simply to show you what the
tag update does.

I checked in the patches on the MOZILLA_1_8_BRANCH and
MOZILLA_1_8_0_BRANCH.

Checking in client.mk;
/cvsroot/mozilla/client.mk,v  <--  client.mk
new revision: 1.245.2.37; previous revision: 1.245.2.36
done

Checking in client.mk;
/cvsroot/mozilla/client.mk,v  <--  client.mk
new revision: 1.245.2.6.24.13; previous revision: 1.245.2.6.24.12
done

Comment 14

[Carsten Book [:Tomcat]]

verified fixed for 1.8.0.12 and 1.8.1.4 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.0.12) Gecko/20070508 Firefox/1.5.0.12 and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4) Gecko/20070509 Firefox/2.0.0.4 ID:2007050903

Comment 15

[juan becerra [:juanb]]

Verified in Thunderbird 2.0.0.4rc1, nspr4.dll version in Tbird installation says: 4.6.7.0