379192 - [suiterunner] Drop-down button in location/url bar looks pressed: missing shades around !?

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070428 SeaMonkey/1.5a] (nightly) (W2Ksp4)

No bug.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007042901 SeaMonkey/1.5a] (suiterunner, tinderbox-builds) (W2Ksp4)

Drop-down button in url bar looks (inactive but) pressed:
missing shades around !?
(or wrong size ? I think I remember some bug/comment about this ! But don't find it.)

NB:
When pressing the button, the central arrow changes from "gray" to "black" ... then there are still two states.

Comment 1

[Robert Kaiser]

Target milestone is to be set for someone who is the assignee but there is none yet.

Anyways, from my talk with stefanh on IRC, this is probably caused by us using xpfe autocomplete with toolkit's autocomplete.css - and it's connected with bug 384821

Comment 2

[Manuel Reimer]

Attachment: Try for a fix

This patch may fix both bugs, but we have a much more serious problem:

As soon as this one is fixed, I have the Windows-style address bar... With SeaMonkey 1.x, we had a "GTK-style" addressbar and firefox also has it. I think we should select the theme, where we get our /global, based on the target OS...

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Created an attachment (id=268788) [details]
> Try for a fix

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/2007062001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

I applied this fix to classic.jar and it fixed the bug :-)

Comment 4

[[e-mail]]

Attachment: Another try at a fix

Just move all the browser rules into... browser!

To see the effect, hide the navigation bar and press Ctrl+L. Without this patch, you see the Firefox dropmarker, which doesn't make sense in that context.

Comment 5

[Asaf Romano (gone)]

Comment on attachment 292336 [details] [diff] [review]
Another try at a fix

Hrm, with this change, how would an autocomplete widget look without tweaking its style rules? autocomplete.css should at least provide some fallbacks, I think.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 292336 [details] [diff] [review]
Another try at a fix

comment 5

Comment 7

[[e-mail]]

Comment on attachment 292336 [details] [diff] [review]
Another try at a fix

The default dropmarker styling is in (surprise) dropmarker.css; at least on Windows, no other styles are necessary. Doesn't this work on other platforms?

Comment 8

[Asaf Romano (gone)]

Gah, I forgot enn did that, sorry.

Comment 9

[Tobias Fischer]

Humm, just seen, that this issue don't exist anymore since SeaMonkey 2.0pre Windows-Nightly Build 2008012001. 

Don't know which chekin has fixed this, but I suspect the patches for Bug 397331 or/and Bug 412017 have done it, almost for Windows-Builds. 

For the Moment I will leave this open, but it would be nice, if someone can verify that this Bug is fixed now and can be closed.

Comment 10

[Serge Gautherie (:sgautherie)]

Right !

V.Fixed between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011902 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008012001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

<http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&sortby=Date&hours=2&date=explicit&mindate=2008-01-19+02&maxdate=2008-01-20+02&cvsroot=%2Fcvsroot>
Bug 397331 seems to be the only match.
(Bug 412017 is specific to Linux/GTK.)

***

Manuel, Neil,
could you check if any part of your patches would still be wanted, in addition to bug 397331 ?

Comment 11

[Dão Gottwald [:dao]]

The pinstripe part could still be wanted. We weren't sure about that in bug 397331.

Comment 12

[[e-mail]]

(In reply to comment #10)
>could you check if any part of your patches would still be wanted
As far as I'm concerned this bug is fixed, because it's filed under Windows ;-)

(In reply to comment #11)
>The pinstripe part could still be wanted.
Isn't proto due to land? Probably better wait until after then.

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
> Isn't proto due to land? Probably better wait until after then.

Yes, but I don't think it's going to change the dropmarker, so the question will remain the same: Is |-moz-appearance: menulist-button| better than the non-native dropmarker for apps using autocomplete on OS X? Alex tried to answer that in bug 397331 comment 29. He says the non-native dropmarker is good as a general solution for the autocomplete widget. However, the comparison with the native appearance is still missing.