379217 - "ASSERTION: aFrame is already associated with a region" with float in button

Status: RESOLVED WORKSFORME

(Core :: Layout: Floats, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: aFrame is already associated with a region: '!GetFrameInfoFor(aFrame)', file /Users/jruderman/trunk/mozilla/layout/generic/nsSpaceManager.cpp, line 866

Comment 1

[Boris Zbarsky [:bzbarsky]]

It looks like we reflow the float on the first line, then push the float placeholder on the overflow list of the inline in question (together with the text "bbb", etc).  So we end up reflowing the float _again_ on the second line, and that's when we assert...

Note also the warning about the float cache not matching the actual float list that ensues.

Comment 2

[Jesse Ruderman]

Is the rendering correct?  It seems strange to me that the seemingly adjacent "aaa" and "bbb" are split, but I'm not really familiar with the rules for floats.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I don't think we should be splitting the text there, no.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

New textframe doesn't split there. That also means it suppresses this bug, although the underlying issue is probably still around.

Comment 5

[Jesse Ruderman]

WFM with this testcase on trunk (since new textframe has landed).  It would be nice if someone would create a new testcase that still demonstrates the bug.

Comment 6

[Jesse Ruderman]

Attachment: testcase 2

I see the assertion on Mac trunk with this testcase.  Does it demonstrate the same bug or a different bug?

Comment 7

[Jesse Ruderman]

WFM with both testcases now.

roc, is the underlying issue you mentioned in comment 4 still around?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't know, but if testcase2 is WFY, then I have no reason to believe it is.

Comment 9

[Jesse Ruderman]

Ok.

Comment 10

[Jesse Ruderman]

I checked in both testcases as crashtests.