379274 - Should not be possible to delete or detach attachments from signed/encrypted mails (SeaMonkey)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[g.s]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1

When you removed an attachment from an S/MIME-signed email, the signature is removed as well and Seamonkey does no longer display the body of this email.

Reproducible: Always

Steps to Reproduce:
1. Attach a file
2. Use S/MIME to sign the mail
3. Send the mail
4. Remove th attachment in your "Sent" folder (or from a received mail)
5. Try to read the mail

Actual Results:  
The signature is removed from the mbox file (not a real problem, it would be invalid, anyway) and you can no longer view the message body.

Expected Results:  
Seamonkey should still display the message body and tell me that the signature is invalid or missing.

Comment 1

[Frank Wein [:mcsmurf]]

It should actually not be possible to delete attachments from such mails, see Bug 288273 (until Bug 297314 is fixed). But this was only fixed for Thunderbird. Changing this bug to SeaMonkey version of that one.

Comment 2

[g.s]

IMO it should be possible. If you send a signed email with attachments, you might want to remove the attachment from your Sent-Folder. And you don't need to verify the signature, the receipients do.

Comment 3

[Frank Wein [:mcsmurf]]

Yes, but as long as this is not possible without bugs like you mentioned in Comment 0, this function should get disabled.

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 263482 [details] [diff] [review]
Patch

Most of the changes from Bug 288273 were already in the code, so I only needed to port the change to that function.

Comment 6

[[e-mail]]

Comment on attachment 263482 [details] [diff] [review]
Patch

>   var uri = GetLoadedMessage();
>-  return !IsNewsMessage(uri) && (!IsImapMessage(uri) || CheckOnline());
>+  var canDetach = !IsNewsMessage(uri) && (!IsImapMessage(uri) || CheckOnline());
>+  if (canDetach && ("content-type" in currentHeaderData))
>+  {
>+    var contentType = currentHeaderData["content-type"].headerValue;
>+    canDetach = contentType.indexOf("application/x-pkcs7-mime") < 0 && 
>+                contentType.indexOf("application/x-pkcs7-signature") < 0;
>+  }
>+  return canDetach;
Please rewrite this along these lines:
if ("content-type" in currentHeaderData &&
    /regexp left as an exercise/.test(blah))
  return false;
var uri = GetLoadedMessage();
return blah;
If you want me to test it I'll need a sample signed attachment.

Comment 7

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

Comment 8

[[e-mail]]

Comment on attachment 263879 [details] [diff] [review]
Patch 2

.test not /.

Comment 9

[Frank Wein [:mcsmurf]]

Checking in msgHdrViewOverlay.js;
/cvsroot/mozilla/mailnews/base/resources/content/msgHdrViewOverlay.js,v  <--  msgHdrViewOverlay.js
new revision: 1.155; previous revision: 1.154
done