379336 - JS strict warnings and error in updates.js when checking for newer versions

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4pre) Gecko/20070430 BonEcho/2.0.0.4pre

Checking for a new available version of Firefox and Thunderbird results in following strict warnings and errors in updates.js:

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://mozapps/content/update/updates.js
Line: 520
Source Code:
}

Warning: variable progress hides argument
Source File: chrome://mozapps/content/update/updates.js
Line: 1366, Column: 8
Source Code:
    var progress = Math.round(100 * (progress/maxProgress));

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://mozapps/content/update/updates.js
Line: 1688
Source Code:
};

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://mozapps/content/update/updates.js
Line: 1716
Source Code:
};

Warning: function set_pageIndex does not always return a value
Source File: chrome://global/content/bindings/wizard.xml
Line: 109, Column: 20
Source Code:
          return val;

The following error only appears if a new version is available:

Error: [Exception... "'Failure' when calling method: [nsIWritablePropertyBag::getProperty]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mozapps/content/update/updates.js :: anonymous :: line 725"  data: no]
Source File: chrome://mozapps/content/update/updates.js
Line: 725

Comment 1

[Joey Minta]

Attachment: patch

This was the only strict warning I got when checking for updates

Comment 2

[Simon Bünzli]

(In reply to comment #1)
> This was the only strict warning I got when checking for updates

The other warnings seem to already have been fixed on Trunk but not on the 1.8.1 branch.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'd assigned this bug to myself because I wanted to work on that. But if you wanna do that I'm glad.

Meanwhile I don't get any warning anymore with current trunk builds. Instead an error and multiple exceptions of the same unknown location are thrown:

Error: gUpdates.wiz has no properties
Source File: chrome://mozapps/content/update/updates.js
Line: 862

Error: [Exception... "'Component does not have requested interface' when calling method: [nsIInterfaceRequestor::getInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "<unknown>"  data: no]

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed by the checkin of bug 324121.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Errors dont appear anymore. Marking as verified.