379383 - [FIX]Testcase from bug 348185 triggers ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Martijn Wargers (dead)]

The testcase from bug 348185 triggers 2 times this assertion for me, while loading:
###!!! ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync: 'GetPrevCon
tinuation() || (GetStyleContext()->GetPseudoType() == nsCSSAnonBoxes::mozAnonymo
usBlock) || (nsRefPtr<nsStyleContext>(GetFirstLetterStyle(presContext)) != nsnul
l) == ((mState & NS_BLOCK_HAS_FIRST_LETTER_STYLE) != 0)', file c:/mozilla/mozill
a/layout/generic/nsBlockFrame.cpp, line 5959

This assertions seems to have been added in the patch for bug 362901.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Better assert

I'm not that happy with this, but I can't think of a better way to write this assert...

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 263405 [details] [diff] [review]
Better assert

r+sr=dbaron, although you might want to mention {ib} splits as specifically disallowed in the comment

Comment 3

[Boris Zbarsky [:bzbarsky]]

Checked in, with that change.

Comment 4

[Daniel Veditz [:dveditz]]

Not needed for branch unless we take bug 362901

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8.1.7 by checkin for bug 362901.