379438 - Fix "password stealing" for the 1.8.0 branch/Camino 1.0.5

Status: RESOLVED FIXED

(Camino Graveyard :: Security, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The trio of bug 361463 / bug 172842 / bug 372866 fixed password stealing and its regression on the 1.8branch and trunk.

Stuart said the final patch will be different enough from all three, so I'm filing a separate bug to make tracking and patching easier to follow.

Comment 1

[Stuart Morgan]

Attachment: fix

The logic is brought over as closely as possible from the existing 1.8 branch code.

This patch is lets us use the 1.8 branch nib directly, so that the localizers don't have to do extra work. I compared the wording changes in the other dialogs and there's nothing that should be a problem.

Comment 2

[Josh Aas]

Comment on attachment 266420 [details] [diff] [review]
fix

I'm not entirely comfortable with this going onto the long-stable 1.8.0 branch, but if you really want it go for it. I'm OK with it going in, but if you have any reservations about stability please don't do it. It would be OK to WONTFIX this for the 1.8.0 branch I think.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 266420 [details] [diff] [review]
fix

sr=pink

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 266420 [details] [diff] [review]
fix

sr=pink

Comment 5

[Stuart Morgan]

Landed on MOZILLA_1_8_0_BRANCH