Closed
Bug 379440
Opened 19 years ago
Closed 19 years ago
[FIX]Cursor fallback broken if image completely fails to load
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(
URL
)
Details
Attachments
(1 file, 1 obsolete file)
|
5.76 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
We don't skip over array values that are not images, so sometimes don't get to the fallback...
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #263444 -
Flags: superreview?(dbaron)
Attachment #263444 -
Flags: review?(dbaron)
This is only a problem if they're all not images, and thus arrayLength is 0, right? If so, why not just fix the list2 / list twiddling so that we go through list in the first loop?
Can you add a test for this using computed style?
Comment on attachment 263444 [details] [diff] [review]
Fix
minus based on the previous comments; (list2 could perhaps be renamed to listStart)
Attachment #263444 -
Flags: superreview?(dbaron)
Attachment #263444 -
Flags: superreview-
Attachment #263444 -
Flags: review?(dbaron)
Attachment #263444 -
Flags: review-
|
|
Assignee | |
Comment 4•19 years ago
|
||
Attachment #263444 -
Attachment is obsolete: true
Attachment #263557 -
Flags: superreview?(dbaron)
Attachment #263557 -
Flags: review?(dbaron)
Comment on attachment 263557 [details] [diff] [review]
Updated to commnets
If you're going to iterate through listStart, you should go back to calling it list2.
r+sr=dbaron with that
Attachment #263557 -
Flags: superreview?(dbaron)
Attachment #263557 -
Flags: superreview+
Attachment #263557 -
Flags: review?(dbaron)
Attachment #263557 -
Flags: review+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Checked in with s/listStart/list2/
Status: NEW → RESOLVED
Closed: 19 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•