379529 - On insertion, the auto-incremented field must not appear in the SQL statement

Status: RESOLVED FIXED

(Testopia :: General, defect)

Description

[Frédéric Buclin]

You have to let the DB increment the field value automatically. Setting its value to 'undef' is incorrect, at least on PostgreSQL as it will try to insert NULL. There are several places affected by this issue. I will fix them all at once in a single patch.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I could successfully install Testopia on PostgreSQL with this patch applied. Then I added a new test plan type with no problem. Maybe a bit light for a test, but it seems to run fine. ;)

Comment 2

[Greg Hendricks]

 Checking in Bugzilla/Testopia/Attachment.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Attachment.pm,v  <--  Attachment.pm
    new revision: 1.13; previous revision: 1.12
    done
    Checking in Bugzilla/Testopia/TestCase.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/TestCase.pm,v  <--  TestCase.pm
    new revision: 1.32; previous revision: 1.31
    done
    Checking in Bugzilla/Testopia/Environment.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Environment.pm,v  <--  Environment.pm
    new revision: 1.13; previous revision: 1.12
    done
    Checking in Bugzilla/Testopia/Build.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Build.pm,v  <--  Build.pm
    new revision: 1.8; previous revision: 1.7
    done
    Checking in Bugzilla/Testopia/Category.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Category.pm,v  <--  Category.pm
    new revision: 1.6; previous revision: 1.5
    done
    Checking in Bugzilla/Testopia/TestCaseRun.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/TestCaseRun.pm,v  <--  TestCaseRun.pm
    new revision: 1.32; previous revision: 1.31
    done
    Checking in Bugzilla/Testopia/TestRun.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/TestRun.pm,v  <--  TestRun.pm
    new revision: 1.27; previous revision: 1.26
    done
    Checking in Bugzilla/Testopia/TestTag.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/TestTag.pm,v  <--  TestTag.pm
    new revision: 1.6; previous revision: 1.5
    done
    Checking in Bugzilla/Testopia/TestPlan.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/TestPlan.pm,v  <--  TestPlan.pm
    new revision: 1.38; previous revision: 1.37
    done
    Checking in Bugzilla/Testopia/Environment/Element.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Environment/Element.pm,v  <--  Element.pm
    new revision: 1.8; previous revision: 1.7
    done
    Checking in Bugzilla/Testopia/Environment/Category.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Environment/Category.pm,v  <--  Category.pm
    new revision: 1.7; previous revision: 1.6
    done
    Checking in Bugzilla/Testopia/Environment/Property.pm;
    /cvsroot/mozilla/webtools/testopia/Bugzilla/Testopia/Environment/Property.pm,v  <--  Property.pm
    new revision: 1.7; previous revision: 1.6
    done
    Checking in tr_install.pl;
    /cvsroot/mozilla/webtools/testopia/tr_install.pl,v  <--  tr_install.pl
    new revision: 1.24; previous revision: 1.23
    done