Closed
Bug 379542
Opened 17 years ago
Closed 17 years ago
remove support for NS_THEME_BUTTON_SMALL
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha5
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(3 files)
|
1.65 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
|
6.92 KB,
patch
|
cbarrett
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
691 bytes,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
As of bug 379297 button-small isn't really any different than a regular button, so we should clean up our usage of button-small in pinstripe to make sure everything displays correctly.
Flags: blocking-firefox3?
Attachment #263729 -
Flags: review?
Attachment #263729 -
Flags: review? → review?(bienvenu)
|
||
Updated•17 years ago
|
Attachment #263729 -
Flags: review?(bienvenu) → review+
Attachment #263739 -
Flags: review?(mano)
Note - the gecko fix won't land until the rest of our consumers have fixes ready.
|
||
Comment 5•17 years ago
|
||
Comment on attachment 263739 [details] [diff] [review] gecko fix v1.0 I'm not a peer of any of the covered modules.
Attachment #263739 -
Flags: review?(mano)
Attachment #263739 -
Flags: review?(cbarrett)
|
||
Updated•17 years ago
|
Attachment #263739 -
Flags: review?(cbarrett) → review+
Attachment #263739 -
Flags: superreview?(pavlov)
|
|
||
Comment 6•17 years ago
|
||
Or, to put it another way, a layout peer should review/moa this patch.
Attachment #263739 -
Flags: superreview?(pavlov) → superreview?(roc)
Comment on attachment 263739 [details] [diff] [review] gecko fix v1.0 r+sr=me
Attachment #263739 -
Flags: superreview?(roc) → superreview+
Attachment #263968 -
Flags: review?(mano)
|
|
||
Comment 9•17 years ago
|
||
Comment on attachment 263968 [details] [diff] [review] toolkit fix v1.0 r=mano, but either replace your two spaces with a hard tab or fix the other lines inside this rule.
Attachment #263968 -
Flags: review?(mano) → review+
|
Assignee | |
Comment 10•17 years ago
|
||
fixed on trunk, landed gecko support removal and toolkit consumer. calendar guys will get rid of the calendar consumer here in a bit.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: blocking-firefox3?
Resolution: --- → FIXED
Component: General → Widget: Cocoa
Product: Firefox → Core
Summary: clean up button-small usage in pinstripe → remove support for NS_THEME_BUTTON_SMALL
Target Milestone: --- → mozilla1.9alpha5
Version: unspecified → Trunk
|
||
Comment 11•17 years ago
|
||
calendar is done on trunk
Was anybody outside of our source using this?
|
|
Assignee | |
Comment 13•17 years ago
|
||
Not that I am aware of.
|
||
Comment 14•17 years ago
|
||
I was.
It was the only way I could figure out to create a really minimal, yet accessible (oncommand!) "chromeless" picture button in XUL (+CSS).
{ -moz-appearance:button-small; margin:0; padding:0; min-width:0; border:none; }
Although it never worked on the mac, it was a good thing to allow a ui designer to do his thing with buttons and not force the OS look on him. Especially in my extension where everything has to be done in minimal space.
Hey! I kindly request you move this back in.
before:
http://sms.chic-happens.ch/images/bugzilla.mozilla.org/button-small.before.png
after:
http://sms.chic-happens.ch/images/bugzilla.mozilla.org/button-small.after.png
Never forget the poor, unknown people working on extensions!
You need to log in
before you can comment on or make changes to this bug.
Description
•