379579 - implement IAccessibleHypertext

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[[e-mail]]

Comment on attachment 263568 [details] [diff] [review]
patch

>+class CAccessibleHypertext: public CAccessibleText,
>+                            public IAccessibleHypertext
Why does CAccessibleHypertext need to derive from CAccessibleText?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> (From update of attachment 263568 [details] [diff] [review])
> >+class CAccessibleHypertext: public CAccessibleText,
> >+                            public IAccessibleHypertext
> Why does CAccessibleHypertext need to derive from CAccessibleText?
> 

because IAccessibleHypertext is inherited from IAccessibleText. I am getting IAccessibleText implementation from CAccessibleText.

Comment 3

[Aaron Leventhal]

Comment on attachment 263568 [details] [diff] [review]
patch

I like it other than the macro:
GET_NSIACCESSIBLEHYPERTEXT

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

with aaron's comments

Comment 5

[[e-mail]]

(In reply to comment #2)
>I am getting IAccessibleText implementation from CAccessibleText.
Right, but why not make nsHyperTextAccessibleWrap to derive from both CAccessibleText and CAccessibleHyperText instead?

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #5)
> (In reply to comment #2)
> >I am getting IAccessibleText implementation from CAccessibleText.
> Right, but why not make nsHyperTextAccessibleWrap to derive from both
> CAccessibleText and CAccessibleHyperText instead?
> 

Yes, then I should declare FORWARD_IACCESSIBLETEXT(CAccessibleText) on nsHyperTextAccessibleWrap instead CAccessibleHyperText and I should do it everywhere where I want to use CAccessibleHyperText. Right?

Comment 7

[Aaron Leventhal]

Here, make sure the QI to the XPCOM hyper text interface succeeds first.

  if (IID_IAccessibleHypertext == iid) {

    *ppv = NS_STATIC_CAST(IAccessibleHypertext*, this);

    (NS_REINTERPRET_CAST(IUnknown*, *ppv))->AddRef();

    return S_OK;

Comment 8

[Aaron Leventhal]

And if you haven't already, do that for all the other XPCOM interfaces with IA2 equivalents.

Comment 9

[[e-mail]]

Comment on attachment 263994 [details] [diff] [review]
patch2

(In reply to comment #6)
>Yes, then I should declare FORWARD_IACCESSIBLETEXT(CAccessibleText) on
>nsHyperTextAccessibleWrap instead CAccessibleHyperText and I should do it
>everywhere where I want to use CAccessibleHyperText. Right?
My fault, I keep thinking that C++ interfaces work like Java interfaces and they don't. Your original way is fine.

Comment 10

[Aaron Leventhal]

Surkov, is this one ready to go in?

Comment 11

[alexander :surkov (:asurkov)]

Attachment: patch3

(In reply to comment #10)
> Surkov, is this one ready to go in?
> 

this one - yes :)

Comment 12

[alexander :surkov (:asurkov)]

checked in