379588 - suiterunner: Palm Sync extension causes tinderbox to fail its build

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Mark Banner (:standard8)]

I'm not sure where to put this bug at the moment, so build config will do in the first instance.

I think tpol is failing to build suiterunner due to palm sync extension.

Since I changed the palmsync installation location to p@m to match the extension ID, it now registers correctly in suiterunner on startup.

The problem with this is that when starting with a new profile and palmsync we automatically start the executable to install the palm sync conduit which, by default prompts but it doesn't block suiterunner starting).

So the tinderbox builds will run tests successfully, but because the installer never gets killed, next time round, tpol can't remove the installer exe and hence fails the build.

There is a pref which is set to determine if to start the installer or not, so I don't know if we could/would be able to override that for the tinderboxes.

Starting the installer automatically is a new (useful) feature which is why we never saw it before.

Any suggestions on how to get round this problem?

Comment 1

[[e-mail]]

(In reply to comment #0)
>There is a pref which is set to determine if to start the installer or not, so
>I don't know if we could/would be able to override that for the tinderboxes.
Update run_all_tests in build-seamonkey-util.pl and add another set_pref call.

Comment 2

[Robert Kaiser]

Yes, probably would be best to do a tinderbox patch for that.

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Yes, probably would be best to do a tinderbox patch for that.

I can do one later

Comment 4

[Mark Banner (:standard8)]

Attachment: Tinderbox fix

The fix, Robert's going to test this on tpol before we submit it for review.

Comment 5

[Mark Banner (:standard8)]

Attachment: Tinderbox fix v2

Better version to include Thunderbird as well in case they get Palm Sync building set up again.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 263619 [details] [diff] [review]
Tinderbox fix v2

tpol seems to be holding green now, so requesting review for this tinderbox patch.

Comment 7

[Mark Banner (:standard8)]

Patch checked in, so this should be fixed now.