Starting Firefox or Thunderbird 2.0.0.4 prints "Handling command line!"

RESOLVED FIXED

Status

()

Toolkit
Startup and Profile System
--
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Frédéric Buclin, Assigned: bsmedberg)

Tracking

({regression, verified1.8.1.4})

1.8 Branch
x86
Linux
regression, verified1.8.1.4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
That's a "regression" due to bsmedberg's fix in bug 375710. The debug message has not been removed on checkin.
Flags: blocking1.8.1.5?
Flags: blocking1.8.1.4?
I was going to point at bug 375710 comment 100 saying it should only show up for people who explicitly turn on a debugging pref, but it turns out the debugging pref only affects dump() used in a DOM context (window.dump()). JS components dump() is enabled all the time and this really should be removed.

We should also file a bug to "fix" dump() in JS components to prevent this confusion in the future, one of
 - make it obey the pref
 - make it debug-build-only if pref too hard
 - rename it to avoid confusion over behavior differences (print?)
Assignee: nobody → benjamin
Blocks: 375710
No longer blocks: 375710
Blocks: 375710
Filed bug 379797 on the dump() confusion.
Created attachment 264010 [details] [diff] [review]
Remove the dump() line

Seeking review, should we want to take this patch for a respin of the release.
Attachment #264010 - Flags: review?(benjamin)
(Assignee)

Comment 4

10 years ago
Comment on attachment 264010 [details] [diff] [review]
Remove the dump() line

We'll need to land this on MOZILLA_1_8_BRANCH as well as the release branch.
Attachment #264010 - Flags: review?(benjamin)
Attachment #264010 - Flags: review+
Attachment #264010 - Flags: approval1.8.1.4?
Comment on attachment 264010 [details] [diff] [review]
Remove the dump() line

approved for 1.8.1.4, a=dveditz for release-drivers

Could also use debug() instead of dump() if you want to leave these in in the future.
Attachment #264010 - Flags: approval1.8.1.4? → approval1.8.1.4+
Checked in on MOZILLA_1_8_BRANCH:

Checking in nsDefaultCLH.js;
/cvsroot/mozilla/toolkit/components/nsDefaultCLH.js,v  <--  nsDefaultCLH.js
new revision: 1.5.8.4; previous revision: 1.5.8.3
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.4
Resolution: --- → FIXED
(Reporter)

Updated

10 years ago
Flags: blocking1.8.1.5?
Flags: blocking1.8.1.4?
(Reporter)

Comment 7

10 years ago
Fixed in version 2.0.0.5pre (20070604)
Keywords: fixed1.8.1.4 → verified1.8.1.4

Updated

9 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
You need to log in before you can comment on or make changes to this bug.