379722 - Starting Firefox or Thunderbird 2.0.0.4 prints "Handling command line!"

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Frédéric Buclin]

That's a "regression" due to bsmedberg's fix in bug 375710. The debug message has not been removed on checkin.

Comment 1

[Daniel Veditz [:dveditz]]

I was going to point at bug 375710 comment 100 saying it should only show up for people who explicitly turn on a debugging pref, but it turns out the debugging pref only affects dump() used in a DOM context (window.dump()). JS components dump() is enabled all the time and this really should be removed.

We should also file a bug to "fix" dump() in JS components to prevent this confusion in the future, one of
 - make it obey the pref
 - make it debug-build-only if pref too hard
 - rename it to avoid confusion over behavior differences (print?)

Comment 2

[Daniel Veditz [:dveditz]]

Filed bug 379797 on the dump() confusion.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Remove the dump() line

Seeking review, should we want to take this patch for a respin of the release.

Comment 4

[Benjamin Smedberg]

Comment on attachment 264010 [details] [diff] [review]
Remove the dump() line

We'll need to land this on MOZILLA_1_8_BRANCH as well as the release branch.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 264010 [details] [diff] [review]
Remove the dump() line

approved for 1.8.1.4, a=dveditz for release-drivers

Could also use debug() instead of dump() if you want to leave these in in the future.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Checked in on MOZILLA_1_8_BRANCH:

Checking in nsDefaultCLH.js;
/cvsroot/mozilla/toolkit/components/nsDefaultCLH.js,v  <--  nsDefaultCLH.js
new revision: 1.5.8.4; previous revision: 1.5.8.3
done

Comment 7

[Frédéric Buclin]

Fixed in version 2.0.0.5pre (20070604)