379823 - Allow conditional skipping of reftests (reporting them as failures)

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Jonathan Watt [:jwatt]]

Attachment: patch

In bug 379600 and bug 357637 we have reftests that crash the linux test machine qm-rhel02 and as a result we can't enable these tests. There's no good reason these tests can't be run on the platforms on which they don't crash though. We just need a mechanism to allow that.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 263857 [details] [diff] [review]
patch

r+sr=dbaron; I think you may as well add skip for symmetry.

Is there an easy way we could make a "KNOWN FAIL" message be printed for skipped tests?  If so, maybe a followup patch?

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch with the addition of 'skip' and error reporting

Yeah, we should report the failure. Good idea. Also, if we're going to report skipped tests as failures then it makes sense to add a 'skip' command. Here's a patch do add 'skip' to 'skip-if' and add error reporting.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 263911 [details] [diff] [review]
patch with the addition of 'skip' and error reporting

r+sr=dbaron

Comment 4

[Jonathan Watt [:jwatt]]

checked in