379841 - nsIZipReader's last modified time ignores seconds

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Description

[Dave Townsend [:mossop]]

The ZIP specification allows for storing last modified times down to a 2 second resolution. Our zipreader however ignores the seconds on retrieval. What's more it's method of converting that time is somewhat inefficient in my book.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Uses direct time calculations including the seconds as well.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 263913 [details] [diff] [review]
patch rev 1

a unit test would be nice

Comment 3

[Dave Townsend [:mossop]]

Attachment: unit test

This is a unit test, confirmed that it fails without the patch in this bug and succeeds with it.

Comment 4

[Dave Townsend [:mossop]]

Attachment: testcase for unit test

This is the zip file used as a testcase. Just contains an empty file.

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 2

This is an updated patch that works correctly in all timezones.

We need to use NormalizeTime to fill out the PRExplodedTime so that the correct time zone details can be calculated.

We have to compare against a local time in the unit test because the zip time is held as a local time.

Comment 6

[Nickolay_Ponomarev]

mozilla/modules/libjar/nsJAR.cpp                          1.128
mozilla/modules/libjar/test/unit/test_bug379841.js        1.1
mozilla/modules/libjar/test/unit/data/test_bug379841.zip  1.1