Closed Bug 379985 Opened 18 years ago Closed 18 years ago

[Pinstripe] Use Highlight and highlighttext where applicable

Categories

(Toolkit :: UI Widgets, defect)

PowerPC
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9alpha5

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(1 file)

Since we now have a real "Higlight" color that is changeable in system prefs, we can get rid of the -moz-mac-alternateprimaryhighlight" stuff. We can also use "highlighttext" instead of a hard-coded white color.
Depends on: 371609
Status: NEW → ASSIGNED
Comment on attachment 265387 [details] [diff] [review] Don't use -moz-mac-alternateprimaryhighlight and hard-coded white color r=mano on the tookit/ part.
Attachment #265387 - Flags: review?(mano) → review+
Comment on attachment 265387 [details] [diff] [review] Don't use -moz-mac-alternateprimaryhighlight and hard-coded white color David, can you review the mail part? I'm not sure if this require sr... (but if it does, perhaps you could sr it as well - there's no flag to set).
Attachment #265387 - Flags: review?(bienvenu)
Attachment #265387 - Flags: approval-thunderbird3?
Comment on attachment 265387 [details] [diff] [review] Don't use -moz-mac-alternateprimaryhighlight and hard-coded white color looks simple, and fine for the mail part. thx, Stefan
Attachment #265387 - Flags: review?(bienvenu) → review+
Comment on attachment 265387 [details] [diff] [review] Don't use -moz-mac-alternateprimaryhighlight and hard-coded white color It appears that r or sr from mcscott/bienvenu is enough to land the mail part.
Attachment #265387 - Flags: approval-thunderbird3?
Checking in mail/themes/pinstripe/mail/mailWindow1.css; /cvsroot/mozilla/mail/themes/pinstripe/mail/mailWindow1.css,v <-- mailWindow1.css new revision: 1.11; previous revision: 1.10 done Checking in toolkit/themes/pinstripe/global/autocomplete.css; /cvsroot/mozilla/toolkit/themes/pinstripe/global/autocomplete.css,v <-- autocomplete.css new revision: 1.7; previous revision: 1.6 done Checking in toolkit/themes/pinstripe/global/listbox.css; /cvsroot/mozilla/toolkit/themes/pinstripe/global/listbox.css,v <-- listbox.css new revision: 1.6; previous revision: 1.5 done Checking in toolkit/themes/pinstripe/global/tree.css; /cvsroot/mozilla/toolkit/themes/pinstripe/global/tree.css,v <-- tree.css new revision: 1.15; previous revision: 1.14 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: