380090 - problems moving livemarks around in the organize bookmarks dialog, leads to js errors and problems

Status: RESOLVED DUPLICATE of bug 372051

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

problems moving livemarks around in the organize bookmarks dialog, leads to js errors and problems.

here are the errors:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._ans.setAnnotation is not a function" {
file: "file:///c:/builds/trunk-no-places/mozilla/ff-debug/dist/bin/components/ns
LivemarkService.js" line: 1094}]' when calling method: [nsILivemarkService::onCo
ntainerMoved]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAIL
S)"  location: "JS frame :: chrome://browser/content/places/controller.js :: PMF
T_doTransaction :: line 1736"  data: yes]
************************************************************
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file c:/builds/trunk-no-places
/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 1571
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._ans.setAnnotation is not a function" {
file: "file:///c:/builds/trunk-no-places/mozilla/ff-debug/dist/bin/components/ns
LivemarkService.js" line: 1094}]' when calling method: [nsILivemarkService::onCo
ntainerMoved]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAIL
S)"  location: "JS frame :: chrome://browser/content/places/controller.js :: PMF
T_doTransaction :: line 1736"  data: yes]
************************************************************

here is the problem:

426     this._ans.setAnnotation(newURI, LMANNO_FEEDURI, feedURIString, 0, 
427                             this._ans.EXPIRE_NEVER);

the fix is to switch to this._ans.setAnnotationString() in two places

/toolkit/components/places/src/nsLivemarkService.js, line 426 -- this._ans.setAnnotation(newURI, LMANNO_FEEDURI, feedURIString, 0, 
/toolkit/components/places/src/nsLivemarkService.js, line 440 -- this._ans.setAnnotation(newURI, LMANNO_SITEURI, siteURIString, 0,

coming up next, after I very the fix, will be some simple steps to reproduce.

Comment 2

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv