380142 - Growl doesn't support click notification

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Robert Accettura [:raccettura]]

Attachment: Testcase

Bug 362685 implemented Growl.

When using nsIAlertsService and specifying an alertListener for the  showAlertNotification() method, one would expect a callback if the alert is clicked.  None is sent.

I've attached a testcase.  On Windows it functions correctly.  On Mac OS X, the callback never happens.

Comment 1

[Robert Accettura [:raccettura]]

Note: you may need to set signed.applets.codebase_principal_support to true to see the testcase, or view it locally.  Otherwise expect an error.

Comment 2

[Shawn Wilsher :sdwilsh]

Ok, so when I'm running the testcase, I get this:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIAlertsService.showAlertNotification]"  nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)"  location: "JS frame :: https://bugzilla.mozilla.org/attachment.cgi?id=264230 :: <TOP_LEVEL> :: line 25"  data: no]

I'm slightly confused as to what's up with that - and maybe me tree is out of date.  I know this worked at some point because I was using a very similar test case. :/

Comment 3

[Shawn Wilsher :sdwilsh]

Ok, looks to me like it isn't even working (at least on my tree) right now.  This could be do to local changes for the localization bug.  I take it it still displays the notification, just doesn't support the click back?

Comment 4

[Robert Accettura [:raccettura]]

Correct.  Notification appears perfectly (though I'd wish it would hang a second or two longer).

The problem here is that click back never fires.

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> Correct.  Notification appears perfectly (though I'd wish it would hang a
> second or two longer).

We can easily fix this.  Click on the apple icon, go to system preferences, and click on Growl.  From there, click the display options tab, and you'll find a slider for duration.

> The problem here is that click back never fires.
> 

So, clearly I've broken something in my tree that I'll have to fix.  If you don't mind, I'd like you to try one more thing so I can try to pinpoint what is wrong.  What happens if you remove that if statement and just alert the subject, data, and topic in the observer?

Comment 6

[Robert Accettura [:raccettura]]

Attachment: Test 2

3 alerts fired on windows, 0 on mac when clicked.

Comment 7

[Shawn Wilsher :sdwilsh]

Alright, it seems to be a build issue.  I'm betting you have a debug build that it doesn't work in?  I just downloaded a static build, and it works like a charm.  Looks like I need to build it different based on if we have a debug build or not.

Comment 8

[Robert Accettura [:raccettura]]

No, just a nightly I downloaded.  I'll check tomorrow for the build date.

Comment 9

[Shawn Wilsher :sdwilsh]

Sorry, different issue.  On a debug build notifications aren't even displayed. :(

And clickbacks are not working for me on a nightly.  This bug is most annoying.

Comment 10

[Robert Accettura [:raccettura]]

Just in case it's worth anything, it is an Intel Mac, latest Growl, nothing fancy going on here.

Comment 11

[Robert Accettura [:raccettura]]

Yup.  Just tested on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a5pre) Gecko/20070514 Minefield/3.0a5pre

They appear correctly, but no clickbacks.

Comment 12

[Shawn Wilsher :sdwilsh]

Fixed with Bug 378527.

Comment 13

[Robert Accettura [:raccettura]]

Thanks Shawn.  I'll test it tomorrow.

Comment 14

[Robert Accettura [:raccettura]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a5pre) Gecko/20070515 Minefield/3.0a5pre

Still no go using testcases in this bug.

Comment 15

[Shawn Wilsher :sdwilsh]

You've got to be kidding me!?!?  Ug, I wonder if this is a difference with static and dynamic builds.  I probably won't be able to look at this until this weekend.

Comment 16

[Robert Accettura [:raccettura]]

Re-downloaded, deleted profile.  It worked.  No idea what to think here.

Anyway, thanks for the quick fix.