380301 - unable to dnd file links (as bookmarks) under the "Bookmarks" menu

Status: VERIFIED DUPLICATE of bug 337761

(Firefox :: Bookmarks & History, defect, P4)

Description

[(not reading, please use [e-mail] instead)]

unable to dnd file links (as bookmarks) under the "Boomarks" menu

in fx 2, on windows, you could drag a link over the Bookmarks menu and it would open up, allowing you to file where you want (and if you hover over a subfolder, that would open up).

on trunk with places bookmarks, this doesn't work anymore.

Comment 1

[tabmix.onemen]

i see slightly different result:

when i drag link over the bookmark menu it doesn't open

when i drop the link over the bookmark menu, the menu popup for a split second
and new bookmark was added in the bottom of the last used\opened folder.

Comment 2

[(not reading, please use [e-mail] instead)]

I see the same thing as onemen.one.

Comment 3

[Dietrich Ayala (:dietrich)]

finding owners for all the A6 blockers. can you please put a swag in the whiteboard? then we can review and load-balance at the next places meeting.

Comment 4

[Steve Won (stevewon on irc)]

So it seems like the problem is that the timer to bring up a bookmarks menu list initialized on drag enter, but not fired until the mouse click is released. Same goes for the timer with closing the menu list. 

Everything works fine if we just show the popup menu list immediately instead of using the timer to do so with a slight delay.

Would anything be preventing nsITimer.initWithCallback from firing before a click is released? (Not sure if nsITimer always works like that or not).

Any feedback would be helpful. Thanks.

Comment 5

[Steve Won (stevewon on irc)]

So it seems like the problem is that the timer to bring up a bookmarks menu list is initialized on drag enter, but not fired until the drag is released. Same goes for the timer with closing the menu list. 

Everything works fine if we just show the popup menu list immediately instead of using the timer to do so with a slight delay.

Would anything be preventing nsITimer.initWithCallback from firing before a drag is released? (Not sure if nsITimer always works like that or not).

Any feedback would be helpful. Thanks.

Comment 6

[Steve Won (stevewon on irc)]

Attachment: The timer spots I was talking about

This patch shows the timer function & function calls I mentioned.

Comment 7

[Steve Won (stevewon on irc)]

Er, not really a patch.

Comment 8

[Steve Won (stevewon on irc)]

So I asked around, and this seems to be a problem with Windows.
If I understand correctly...nsITimer fires after the mouse release, because drag-n-drop code needs to run in its own event loop which doesn't allow timers to fire.

Comment 9

[Dietrich Ayala (:dietrich)]

retargeting bugs that don't meet the alpha release-blocker criteria at http://wiki.mozilla.org/Firefox3/Schedule.

Comment 10

[(not reading, please use [e-mail] instead)]

neil, can you help out with this?  

(do you think it might be more fall out from the nsIThreadManager change, bug #326273?)

Comment 11

[Neil Deakin]

Yes, and it's the same cause as bug 337761.

Comment 12

[Dietrich Ayala (:dietrich)]

This does not need to block M9.

Comment 14

[Mike Connor [:mconnor]]

Not going to continue to block on this.  If you disagree with this decision, please renominate with reasons why we can't ship with this in final

Comment 15

[(mostly gone) XtC4UaLL [:xtc4uall]]

Renominating for blocking.
Reason is the same as in Bug 389290:
"Because it was fully functional in 2.0 and because it is a basic UI design
requirement.  It looks really bad to regress something like this between final
version implementations.  It is almost a requirement when moving bookmarks
around that you can see where they are going to be dropped.  Otherwise, the UI
feels very disconcerting.  You can still do it, but it is very unprofessional,
and takes away some speed and accuracy from the user."

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv