380398 - appversion manifest flag is broken in certain situations

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Dave Townsend [:mossop]]

The appversion manifest flag is broken if you use a simple comparison (>, <, =) and the version number to compare against is only one digit.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Fixes the length check and adds an additional check that the version to compare was actually specified.

Comment 2

[Dave Townsend [:mossop]]

Checking in nsChromeRegistry.cpp;
/cvsroot/mozilla/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.352; previous revision: 1.351
done

Comment 3

[Dave Townsend [:mossop]]

Attachment: testcase rev 1

This testcase tests a number of scenarios for the appversion flag.

Much of the work involves creating and registering a directory service provider so that we can let the chrome registry know about our testcase manifest file, and then creating a dummy nsIXULAppInfo so we have control over it's version.

Once all that is done it is simply a case of trying to convert a chrome url for each testcase and checking that it succeeds and fails when appropriate.

I have confirmed that this passes at present, and fails with this bug backed out.

Comment 4

[Benjamin Smedberg]

Comment on attachment 266511 [details] [diff] [review]
testcase rev 1

That's pretty cool, thanks!

Comment 5

[Dave Townsend [:mossop]]

Checking in Makefile.in;
/cvsroot/mozilla/chrome/Makefile.in,v  <--  Makefile.in
new revision: 1.9; previous revision: 1.8
done
RCS file: /cvsroot/mozilla/chrome/test/Makefile.in,v
done
Checking in test/Makefile.in;
/cvsroot/mozilla/chrome/test/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/chrome/test/unit/test_bug380398.js,v
done
Checking in test/unit/test_bug380398.js;
/cvsroot/mozilla/chrome/test/unit/test_bug380398.js,v  <--  test_bug380398.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/chrome/test/unit/data/test_bug380398.manifest,v
done
Checking in test/unit/data/test_bug380398.manifest;
/cvsroot/mozilla/chrome/test/unit/data/test_bug380398.manifest,v  <--  test_bug380398.manifest
initial revision: 1.1
done

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 264492 [details] [diff] [review]
patch rev 1

Requesting branch approval for a low risk patch that clears up a bug for add-on authors.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 264492 [details] [diff] [review]
patch rev 1

approved for 1.8.1.5 and 1.8.0.13, a=dveditz for release-drivers

Comment 8

[Dave Townsend [:mossop]]

Checking in nsChromeRegistry.cpp;
/cvsroot/mozilla/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.338.2.4; previous revision: 1.338.2.3
done

Checking in chrome/src/nsChromeRegistry.cpp;
/cvsroot/mozilla/chrome/src/nsChromeRegistry.cpp,v  <--  nsChromeRegistry.cpp
new revision: 1.338.2.1.4.3; previous revision: 1.338.2.1.4.2
done