380499 - 10.3.9 build dies in airbag/airbag/src/common/mac/

Status: RESOLVED WONTFIX

(Toolkit :: Crash Reporting, defect)

Description

[Stefan [:stefanh]]

Mac OS 10.3.9 (gcc3.3) with 10.3.0 sdk:

c++ -o host_macho_id.o -c  -I/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/../..  -I../../../../../../dist/include   -I../../../../../../dist/include/breakpad_mac_common -I../../../../../../dist/include/nspr  -DMOZ_PNG_READ -DMOZ_PNG_WRITE  -I../../../../../../dist/sdk/include -I../../../../../../dist/include/nspr /Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc: In
   static member function `static bool 
   MacFileUtilities::MachoID::WalkerCB(MacFileUtilities::MachoWalker*, 
   load_command*, long long int, bool, void*)':
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:261: error: aggregate
   `MacFileUtilities::mach_header_64 header' has incomplete type and cannot be 
   defined
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:281: error: `
   LC_SEGMENT_64' undeclared (first use this function)
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:281: error: (Each
   undeclared identifier is reported only once for each function it appears 
   in.)
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:282: error: aggregate
   `segment_command_64 seg64' has incomplete type and cannot be defined
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:290: error: aggregate
   `MacFileUtilities::mach_header_64 header' has incomplete type and cannot be 
   defined
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:298: error: invalid
   application of `sizeof' to an incomplete type
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:299: error: aggregate
   `section_64 sec64' has incomplete type and cannot be defined
/Users/Stefan/mozilla-test/mozilla/toolkit/airbag/airbag/src/common/mac/macho_id.cc:308: error: invalid
   application of `sizeof' to an incomplete type
make[6]: *** [host_macho_id.o] Error 1
make[5]: *** [libs] Error 2
make[4]: *** [libs] Error 2
make[3]: *** [libs_tier_toolkit] Error 2
make[2]: *** [tier_toolkit] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

(latest source, airbag/Makefile.in up to date)

Note: This could have happened for some time - I've had build problems which I think was related to this some time ago and I haven't done any building since then. iirc, this problem is different than the previous one, though.

Note also that this is a suiterunner build (SeaMonkey on toolkit), but afaik this shouldn't matter.

Comment 1

[(not currently active) Ted Mielczarek]

As discussed, for now we're just going to recommend --disable-airbag in your situation.  Obviously the Breakpad code doesn't compile on the 10.3.0 SDK due to SDK differences.  We experienced a lot of these just with differences between the 10.3.9 and the 10.4u SDKs.  I'm leaving this open since your SDK is still a supported build configuration, so we should either need to fix this or deprecate that SDK.

Comment 2

[Josh Aas]

Since the PPC part of our release builds must target the 10.3.9 SDK, does this stop us from making universal binaries that run on 10.3.9?

Comment 3

[(not currently active) Ted Mielczarek]

I don't believe so, unless someone has complained about the nightly builds not working.  The problem here is compiling *on* 10.3.9 with the 10.3.0 SDK.  It compiles ok on 10.4.9 targetting the 10.3.9 SDK.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since 10.3 support has been removed from the codebase (or at least from Widget:Cocoa, where it matters), this is now WONTFIX.