380561 - Missing borders when dashed + dotted border-style used

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[philippe (part-time)]

Attachment: test case

Mixed border styling. When a dashed border follows a dotted border (or vice-versa), one of the borders is not painted.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: fix missing borders

Whoops.  So the key part of this patch was changing an
  } else if (startType == ...)
to
  } else if (endType == ...)

Copy-paste got me here.

There's also a bunch of misc debug printfs added, as well as pulling out sideOrder into a gBorderSideOrder.  I also change the side order to be top - right - bottom - left, to match the clip function; David, I finally see what you were saying earlier... I was convinced that the order was TRBL and not BLTR.  I made this match the function; I can change everything to be back to BLTR if you'd rather I do that.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 264808 [details] [diff] [review]
fix missing borders

>+static PRUint8 gBorderSideOrder[] = { NS_SIDE_TOP, NS_SIDE_RIGHT, NS_SIDE_BOTTOM, NS_SIDE_LEFT };

const, please

>-  static PRUint8 sideOrder[] = { NS_SIDE_BOTTOM, NS_SIDE_LEFT, NS_SIDE_TOP, NS_SIDE_RIGHT };

This used to be that way, I think, because we actually drew overlap when we did beveling, and we wanted to draw certain sides on top of others.  That shouldn't be relevant anymore.

r=dbaron

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in (with const).