38057 - Using mozilla to edit the tinderbox message truncates the text

Status: VERIFIED DUPLICATE of bug 15204

(Core Graveyard :: Tracking, defect, P3)

Description

[Simon Fraser [no longer active]]

If you use mozilla to edit the tinderbox message, the text gets truncated, 
resulting in a malformed tinderbox page.

Comment 1

[Peter Trudelle]

Thanks for entering this Simon, but I'm not sure it is this simple.  My 
experience this morning was more than just editing, and could possibly be a 
problem on the server side CGI.  I edited the tbox message, then submitted the 
form without entering a password.  I was then presented with another form that 
contained only authentication.  I entered a correct password and submitted, 
upon which the entire Tinderbox page went blank. My changes had apparently been 
truncated.

Comment 2

[Simon Fraser [no longer active]]

I've been through that same sequence on previous occasions, and it has worked OK. 
I did make a test page, and can certainly get the value of a textarea which 
contains the tinderbox header text with no problems. I guess I need a test which 
involves the CGI.

Comment 3

[Eric Pollmann]

This sounds a lot like bug 37744.  Not sure it's a dup yet though, so keeping 
both open.

Comment 4

[Akkana Peck]

If not 37744, perhaps 22707 (and its clone 29677), where a form submission goes
through fine, into another page with a form which also includes a hidden form
element, and submitting from that form is where the problems show up. 

Comment 5

[Eric Pollmann]

I was able to reproduce this just now, as Peter described (luckily I had saved 
the text in case anything went awry)  Interestingly, following the same series 
of step in Nav resulted in a page with this message rather than the standard 
"Message Changed":

Unknown command "".

This could very easily be server side.  Anyone know where the source for Tbox is 
kept?

Comment 6

[Eric Pollmann]

Akkana, I think you are probably right about this being bug 22707 - though I'd 
have no painless way of testing that unless I had the source of tinderbox.  
Basically, bug 22707 says things like this don't work:

<INPUT TYPE=HIDDEN VALUE="foo
bar">

And that's exactly what we have in the tinderbox MOTD authentication page.

Comment 7

[Daniel (Leaf) Nunes]

the tinderbox source can be pulled from cvs, at mozilla/webtools/tinderbox

Comment 8

[Eric Pollmann]

sandbox is up at:
 http://blueviper/tinderbox/showbuilds.cgi

Thanks leaf!

Comment 9

[Eric Pollmann]

Oh, and the password is:  password

Comment 10

[Eric Pollmann]

Server side fix for Nav:

Index: tbglobals.pl
===================================================================
RCS file: /cvsroot/mozilla/webtools/tinderbox/tbglobals.pl,v
retrieving revision 1.17
diff -r1.17 tbglobals.pl
257c257
<     print "<INPUT TYPE=HIDDEN NAME=$key VALUE='$enc'>\n";
---
>     print "<INPUT TYPE=HIDDEN NAME=$key VALUE=\"$enc\">\n";

The problem is we were quoting the hidden value with single quotes, the value 
contained single quotes, and we were not escaping them.  This fix is to instead 
quote with double quotes, which are escaped.  I'll see if this does the trick 
for Mozilla too...

Comment 11

[Eric Pollmann]

This also fixes the bug for Mozilla.  However, when going through the 
authenticate page, we are still loosing whitespace and linefeeds due to bug 
22707.  This makes the message really difficult to edit the next time around 
(but it's better than loosing it!)

Since this fix isn't for Mozilla, but for tinderbox, is it okay to check in with 
a review and approval?  Who should I get these from?

Comment 12

[Eric Pollmann]

s/Mozilla/Seamonkey/g;

Comment 13

[Eric Pollmann]

(updating mutiple bugs)

Nominating this bug for beta3 because it is either a crasher or a correctness 
bug and I have a straightforward fix in hand.  This bug fix is small, low risk, 
and can easily be reverted with no side effects.

Comment 14

[Kevin McCluskey (gone)]

Marking nsbeta3-. Tinderbox fix - doesn't need beta3 permission

Comment 15

[Eric Pollmann]

Marking dup of bug 15204 - I've asked Tara for approval to check this in.

*** This bug has been marked as a duplicate of 15204 ***

Comment 16

[ckritzer (gone)]

Marking VERIFIED DUPLICATE per pollmann's comments