If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Clear Private Data might miss some SessionStore data

RESOLVED FIXED in Firefox 3 alpha6

Status

()

Firefox
Session Restore
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Simon Bünzli, Assigned: Simon Bünzli)

Tracking

({privacy, verified1.8.1.5})

unspecified
Firefox 3 alpha6
privacy, verified1.8.1.5
Points:
---
Bug Flags:
blocking1.8.1.5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
If private data is cleared when no browser window is visible and Firefox is quit without reopening any browser window, the content of the last open browser window may be restored at restart.

Steps to reproduce:
1. Set browser.preferences.instantApply to true (default on OS X) and configure Firefox to show the windows and tabs from last time on startup
2. Tools -> Options -> Privacy
3. Close all browser windows (take note of the content of the last one)
4. Clear all private data through the still open Options window
5. Close the Options window and all others (resp. quit Firefox)
6. Start Firefox again

Expected result:
Firefox starts blank (as all potentially private data has been cleared).

Actual result:
The last opened window is restored (including related session cookies and recently closed tabs).
(Assignee)

Comment 1

11 years ago
Created attachment 264691 [details] [diff] [review]
one-line fix (and two typos)

One-line omission: data for the last closed window isn't cleared on CPD.

Additionally, this fixes two further nits:
* a comment talking about five seconds when the code obviously says ten
* a variable prefixed as argument when it's not

P.S.: Dietrich, care to reconsider the patch to bug 367605?
Attachment #264691 - Flags: review?(dietrich)
Comment on attachment 264691 [details] [diff] [review]
one-line fix (and two typos)

thanks, r=me.
Attachment #264691 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

10 years ago
Drivers: Do you want this for Firefox 2.0 as well? As you can see in comment #0, it's highly unlikely to be reproduced in the wild. OTOH it's a privacy issue...
Flags: blocking1.8.1.5?
Whiteboard: [checkin needed]

Comment 4

10 years ago
Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.63; previous revision: 1.62
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha6
Version: unspecified → Trunk
Not a blocker for the branch, but ask for approval on the patch and we'll consider it.
Flags: blocking1.8.1.5? → blocking1.8.1.5-
Keywords: privacy
Target Milestone: Firefox 3 alpha6 → ---
Version: Trunk → unspecified
(Assignee)

Comment 6

10 years ago
Created attachment 269288 [details] [diff] [review]
branch patch

Trivial, virtually riskless one-liner: just resetting a variable to its initial value.
Attachment #269288 - Flags: approval1.8.1.5?
Comment on attachment 269288 [details] [diff] [review]
branch patch

approved for 1.8.1.5, a=dveditz for release-drivers
Attachment #269288 - Flags: approval1.8.1.5? → approval1.8.1.5+
(Assignee)

Updated

10 years ago
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: --- → Firefox 3 alpha6
browser/components/sessionstore/src/nsSessionStore.js 1.5.2.45
Keywords: fixed1.8.1.5
Whiteboard: [checkin needed (1.8 branch)]
verified fixed 1.8.1.5 with the steps to reproduce from comment #0 with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.5pre) Gecko/2007071004 BonEcho/2.0.0.5pre - adding verified keyword
Keywords: fixed1.8.1.5 → verified1.8.1.5
You need to log in before you can comment on or make changes to this bug.