380589 - Clear Private Data might miss some SessionStore data

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Simon Bünzli]

If private data is cleared when no browser window is visible and Firefox is quit without reopening any browser window, the content of the last open browser window may be restored at restart.

Steps to reproduce:
1. Set browser.preferences.instantApply to true (default on OS X) and configure Firefox to show the windows and tabs from last time on startup
2. Tools -> Options -> Privacy
3. Close all browser windows (take note of the content of the last one)
4. Clear all private data through the still open Options window
5. Close the Options window and all others (resp. quit Firefox)
6. Start Firefox again

Expected result:
Firefox starts blank (as all potentially private data has been cleared).

Actual result:
The last opened window is restored (including related session cookies and recently closed tabs).

Comment 1

[Simon Bünzli]

Attachment: one-line fix (and two typos)

One-line omission: data for the last closed window isn't cleared on CPD.

Additionally, this fixes two further nits:
* a comment talking about five seconds when the code obviously says ten
* a variable prefixed as argument when it's not

P.S.: Dietrich, care to reconsider the patch to bug 367605?

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 264691 [details] [diff] [review]
one-line fix (and two typos)

thanks, r=me.

Comment 3

[Simon Bünzli]

Drivers: Do you want this for Firefox 2.0 as well? As you can see in comment #0, it's highly unlikely to be reproduced in the wild. OTOH it's a privacy issue...

Comment 4

[Nickolay_Ponomarev]

Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.63; previous revision: 1.62
done

Comment 5

[Daniel Veditz [:dveditz]]

Not a blocker for the branch, but ask for approval on the patch and we'll consider it.

Comment 6

[Simon Bünzli]

Attachment: branch patch

Trivial, virtually riskless one-liner: just resetting a variable to its initial value.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 269288 [details] [diff] [review]
branch patch

approved for 1.8.1.5, a=dveditz for release-drivers

Comment 8

[Phil Ringnalda (:philor)]

browser/components/sessionstore/src/nsSessionStore.js 1.5.2.45

Comment 9

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.5 with the steps to reproduce from comment #0 with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.5pre) Gecko/2007071004 BonEcho/2.0.0.5pre - adding verified keyword