380659 - Incorrect meta tag is used by Save As "Web, page complete" (character encoding specified incorrectly)

Status: VERIFIED FIXED

(Core :: DOM: Serializers, defect)

Description

[Tracy Walker [:tracy]]

seeing this on all platforms with 05/14 trunk builds of Firefox.  I believe may have regressed due to bug 331991.

-load www.google.com
-save page as (choose web page complete)
-load the saved page

test results:  the saved page has an additional character before "more>>" and the copywrite symbol at the bottom of the page.

Comment 1

[[:Aleksej]]

Due to the fix in bug 331991, the meta http-equiv element is replaced, and the new content attribute in it is broken:

Old: content="text/html; charset=UTF-8"

New: content="text/html; UTF-8"

Because of that, the character set is detected automatically, and usually incorrectly.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Please also write a regression test; there should have been one in bug 331991...

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

Patch v1

Should fix the problem.

Comment 4

[[:Aleksej]]

Attachment: simple testcase

Open the testcase. It should show the (R) symbol. If not, select UTF-8 encoding.
Save the testcase to disk (Web Page, complete).
Select View->Character Encoding->Western (ISO-8859-1)
Select View->Character Encoding->Auto-Detect->Off
Open the saved testcase from disk.
It should only show the (R) symbol.
Optionally: check that the meta tag is unchanged and specifies the character encoding the same way as before.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 264776 [details] [diff] [review]
Patch v1

Looks OK, but I still want to see tests for this.

Comment 6

[[:Aleksej]]

followup to #4
Sorry, at least the "Western (ISO-8859-1)" line is wrong; the optional part should be definitive.

Comment 7

[Simon Montagu :smontagu]

Is this waiting for checkin?

Comment 9

[Ryan Jones-Ward [:sciguyryan]]

(In reply to comment #7)
> Is this waiting for checkin?
> 

There isn't any need. This fix is included in the patch for bug 380668 which is marked for checkin.

Comment 10

[Ryan Jones-Ward [:sciguyryan]]

Fixed as part of bug 380668.

Comment 11

[Tracy Walker [:tracy]]

verified with Windows nightly trunk build from 20070619