380669 - List items missing state enabled/sensitive

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[parente]

<select> List items which can be focused, selected should have states enabled and sensitive like other interactive controls.

Comment 1

[Aaron Leventhal]

Attachment: Up call for ENABLED/SENSITIVE/INVISIBLE/OPAQUE/DEFUNCT

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 264909 [details] [diff] [review]
Up call for ENABLED/SENSITIVE/INVISIBLE/OPAQUE/DEFUNCT


>@@ -630,10 +626,13 @@ nsHTMLSelectOptionAccessible::GetState(P
>   if (selectState & nsIAccessibleStates::STATE_COLLAPSED) {
>     // <select> is COLLAPSED: add STATE_OFFSCREEN
>     *aState |= nsIAccessibleStates::STATE_OFFSCREEN;
>   }
>   else {
>+    // XXX list frames are weird, don't rely on nsAccessible's general
>+    // visibility implementation unless they get reimplemented in layout
>+    *aState &= ~nsIAccessibleStates::STATE_OFFSCREEN;
>     // <select> is not collapsed: compare bounds to calculate STATE_OFFSCREEN
>     nsCOMPtr<nsIAccessible> listAccessible = GetParent();
>     if (listAccessible) {
>       PRInt32 optionX, optionY, optionWidth, optionHeight;
>       PRInt32 listX, listY, listWidth, listHeight;


I would probably reogranize this code to set/remove state offscreen only if it is necessary.