380674 - Move nsTObserverArray from content/* to xpcom/*

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

nsTObserverArray would be useful outside gecko.
I think the name should be changed too.
nsTMutableArray is not right, nor is nsTIterativeArray, but the 
current name isn't good one either, IMO, if the class will be used 
also with objects that aren't observers (presShell are only sort of 
observers, bug 378776).

What would be the right place, xpcom/ds or xpcom/glue?
I guess the latter one where also nsTArray and nsVoidArray etc. are.

Btw, if CVS move (with history data and all) is needed, I don't know
how to do that.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

nsTIterationSafeArray, nsTMutationSafeArray, nsTIterableArray.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Though, because observer array doesn't work like a normal array,
maybe the current name is good enough.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Would this be ok? Do we want nsTObserverArray in SDK_HEADERS?

Comment 4

[Benjamin Smedberg]

Comment on attachment 264864 [details] [diff] [review]
v1

>--- /dev/null	2007-05-12 20:28:07.458080988 +0300
>+++ xpcom/glue/nsTObserverArray.h	2007-05-15 13:22:54.000000000 +0300

>+// XXXbz I wish I didn't have to pass in the observer type, but I
>+// don't see a way to get it out of array_.

You can, actually. You just need a typedef in nsTObserverArray

  typedef T elementtype;

(You might need "typename T" to get it to compile.)

Then instead of having to specify obstype_, you can just use array_::elementtype

Comment 5

[Boris Zbarsky [:bzbarsky]]

Oh, good point!  Let's do that, possibly as a followup!