380848 - Selected list item is not reported when focus to the list

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Tim Miao]

Steps to reproduce:
1. Launch orca and thunderbird.
2. Invoke address book import wizard dialog.
3. In second dialog window of import wizard, by default, when this window was firstly brought up, orca will report table list of supported file type.
4. Press Tab to move focus away from this table list item, then move focus back.

Expected result:
Table list should be reported.

Actual result:
It will not be reported when you move focus onto it for second time.

Additional info:
This bug can be found with thunderbird 20070515 trunk nightly build.

Comment 1

[Evan Yan]

If I change focus between windows, Orca will read the texts in the wizard dialog. There is window:active event when changing focus on windows.

For static texts that not label for any controls, which event does Orca depend to read them? just window:active event?

Comment 2

[Evan Yan]

sorry, wrong comment, comment #1 is meant for bug 380695 

Comment 3

[Evan Yan]

When the second page first brought up, there is a focus event fired on the list item, when tab to the list, focus event is fired on the list, but not on the list item. That's why Orca won't read the item.

Should we fire focus event for the selected list item when focus to the list?

Comment 4

[Evan Yan]

In addition, the file type list should be labeled by its above text, bug 381389 filed for this.

Comment 5

[Ginn Chen]

I guess the problem here is, if the list only has one listitem, you could not focus it.

Comment 6

[Aaron Leventhal]

I just checked in a fix for a big regression in nsXULTreeAccessible, does that fix this bug?

The fix was in bug 380976.

Comment 7

[Tim Miao]

To Ginn, there is only one list item, but it was selected by default, you could tab focus onto it.
To Aaron, I will verify this bug later today and give update once I got the trunk build with your fix.

Comment 8

[Tim Miao]

This bug is still visible with thunderbird 3.0a1pre(20070523) build.

Comment 9

[Evan Yan]

The first time the page show up, there is focus event fired for the list item, that's because there is DOMMenuItemActive event fired for the list item.

As Ginn mentioned in comment #5, when list only has one listitem, it will never be focused. So I think the answer to comment #3 is yes.

Comment 10

[Evan Yan]

Actually, we have tried to fire focus event for the selected item, in nsRootAccessible::HandleEventWithTarget() handling "focus" event.

However, it seems a listitem was set as selected AFTER "focus" event comes to listbox. When handling "focus" event, selectControl->GetSelectedItem() returns null.

What's more, we didn't deal with HTML list.

Comment 11

[Evan Yan]

Attachment: fire DOMMenuItemActive when focus to listbox

We fired DOMMenuItemActive when currentItem is set. But when focus to a xul listbox, listitem is focused and selected without currentItem get changed. So focus event on listitem is missed in this case.

The situation gets worse when a listbox has only one listitem. There will never be a focus event on the listitem.

Comment 12

[Evan Yan]

Comment on attachment 289795 [details] [diff] [review]
fire DOMMenuItemActive when focus to listbox

Neil, could you help review this patch, since you were in a discussion of a similar issue in bug 381602?
It's just three lines change.

Comment 13

[[e-mail]]

Comment on attachment 289795 [details] [diff] [review]
fire DOMMenuItemActive when focus to listbox

This will error on an empty listbox. It's probably best to reverse the logic, so you test for a current item first, otherwise you test for an empty list second.

Comment 14

[Evan Yan]

Attachment: patch v2

Thanks for the quick review, here is the updated patch.

Comment 15

[Evan Yan]

mark as block bug 396346, because it makes never a focus event on the only listitem in a listbox.

Comment 16

[[e-mail]]

Comment on attachment 291814 [details] [diff] [review]
patch v2

OK, I guess this version is more readable than what I was thinking of.

Comment 17

[Damon Sicore (:damons)]

Comment on attachment 291814 [details] [diff] [review]
patch v2

a=endgame drivers.

Comment 18

[Evan Yan]

/cvsroot/mozilla/toolkit/content/widgets/listbox.xml,v  <--  listbox.xml
new revision: 1.32; previous revision: 1.31
done