380857 - IE login info migration is broken (can't call nsILoginInfo::Init when using the external string API)

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Since C++ callers like the ones in nsIEProfileMigrator.cpp can't pass in void strings (apparently because the external string API has no such thing), there's no way for them to pass in the "null" that they need to to make nsILoginInfo::Init() behave correctly. nsILoginInfo's compare() functions rely on this distinction when comparing nsILoginInfos, they probably shouldn't.

We need to uncomment the relevant lines in nsIEProfileMigrator.cpp when this is fixed. I think we need to fix this before shipping a5.

Comment 1

[Asaf Romano (gone)]

SetIsVoid?

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Patch v1

This avoids the problem by initializing the known fields directly, instead of using calling Init().

Compiles, but is untested because I upgraded this machine to IE7 yesterday. :-(

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 266331 [details] [diff] [review]
Patch v1

I'm still seeing some weird failure to import certain passwords, but that's almost certainly another bug (perhaps one that's already filed).

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/migration/src/nsIEProfileMigrator.cpp 	1.59

Comment 5

[Mike Connor [:mconnor]]

marking FIXED, unless I'm missing something.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

We fixed the migrator, but not the reliance on void strings. Given the easy workaround and relatively uncommon need, I think leaving things as-is is acceptable. The external string API might eventually get void strings anyways.