Closed Bug 381106 Opened 18 years ago Closed 17 years ago

Right click menu on mac doesn't disappear if you right click on content and then on tabstrip

Categories

(Firefox :: Menus, defect)

x86
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 3 alpha8

People

(Reporter: stevewon, Unassigned)

Details

(Keywords: regression, Whiteboard: [need review josh])

Attachments

(1 file)

Steps to reproduce: *Right click on the content of a webpage *Then right click on a tab *Then click anywhere within the browser window. Result: Right click menu from the tab will disappear. But the right click menu on the content of a webpage wouldn't disappear unless you click on a valid (not grayed out) option. Clicking on other parts of the screen wouldn't do anything. The right click menu on the content of a webpage will be on top when switchin between tabs or on top of a new tab.
Component: General → Menus
QA Contact: general → menus
Version: unspecified → Trunk
Ew... This a cocoa widget bug?
Flags: blocking-firefox3?
Some of us can see this and some of us can't, which means it might be tricky to figure out.
Flags: blocking-firefox3? → blocking-firefox3+
Summary: Right click menu → Right click menu on mac doesn't disappear if you right click on content and then on tabstrip
Attached patch fix?Splinter Review
Not sure if this is a suitable fix, but rolling up the popups in menuForEvent seems to do the trick. There's still some issues with popups possibly caused by bug 279703, which may be fixable by changing nsXULPopupManager:Rollup to pass false to use synchronous rolling up of popups from widget, otherwise some state gets confused trying to open and hide popups.
Attachment #271536 - Flags: review?(joshmoz)
Target Milestone: --- → Firefox 3 M8
Attachment #271536 - Flags: review?(joshmoz)
Attachment #271536 - Flags: superreview?(roc)
Attachment #271536 - Flags: review?(joshmoz)
Attachment #271536 - Flags: superreview?(roc) → superreview+
Whiteboard: [need review josh]
I can no longer reproduce this in current builds. And in any case, by chance a patch exactly like this one was included in the fix for bug 389542, which was just landed on the trunk. So I'm marking this bug FIXED.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #271536 - Flags: review?(joshmoz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: