381108 - Inconsistent use of space after colon in object literal decompilation

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> (function() { return {a:3, b getter: f} }) 
function () {
    return {a:3, b getter: f};
}

It would be nice if there were a space after "a:" like there's a space after "b getter:".  The space after "b getter:" was added in bug 381101.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Trivial fix

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 265189 [details] [diff] [review]
Trivial fix

Cool. Bonus for that followup bug about using JSOP_ANONFUNOBJ2 for genexps instead of a strncmp(..., js_function_str, 8) evil.

/be

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

For the record: I'm waiting to check this in until I have a chance to run the JS testsuite and make sure that none of the tests depend on this inconsistent behavior.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 5

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/js1_7/decompilation/regress-381108.js,v  <--  regress-381108.js
initial revision: 1.1

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac*/windows.