Crash [@ msaa/nsAccessibleWrap::NativeAccessible ]

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, crash, fixed1.8.1.5})

Trunk
All
Windows XP
access, crash, fixed1.8.1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(2 attachments, 2 obsolete attachments)

1.27 KB, patch
Mats Palmgren (vacation - back in August)
: review+
Details | Diff | Splinter Review
1.23 KB, patch
Mats Palmgren (vacation - back in August)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
If nsnull is passed in, we crash. That happens if the caller wasn't able to get an nsIAccessible.
(Assignee)

Comment 1

10 years ago
Created attachment 265190 [details] [diff] [review]
Null checks
Attachment #265190 - Flags: review?(mats.palmgren)
(Assignee)

Comment 2

10 years ago
Created attachment 265191 [details] [diff] [review]
Null checks
Attachment #265191 - Flags: review?(mats.palmgren)
(Assignee)

Updated

10 years ago
Attachment #265190 - Attachment is obsolete: true
Attachment #265190 - Flags: review?(mats.palmgren)
(Assignee)

Comment 3

10 years ago
Created attachment 265193 [details] [diff] [review]
For 1.8.1 branch
Attachment #265193 - Flags: review?(mats.palmgren)
(Assignee)

Comment 4

10 years ago
Created attachment 265194 [details] [diff] [review]
Correct patch for trunk
Attachment #265191 - Attachment is obsolete: true
Attachment #265194 - Flags: review?(mats.palmgren)
Attachment #265191 - Flags: review?(mats.palmgren)
Comment on attachment 265194 [details] [diff] [review]
Correct patch for trunk

Looks good.  I would add an NS_ERROR before the return to catch
future mistakes.  Either way, r=mats
Attachment #265194 - Flags: review?(mats.palmgren) → review+
Comment on attachment 265193 [details] [diff] [review]
For 1.8.1 branch

ditto, r=mats
Attachment #265193 - Flags: review?(mats.palmgren) → review+
(Assignee)

Comment 7

10 years ago
Checked in on trunk with NS_WARNING
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

10 years ago
Attachment #265193 - Flags: approval1.8.1.5?
Comment on attachment 265193 [details] [diff] [review]
For 1.8.1 branch

approved for 1.8.1.5, a=dveditz for release-drivers
Attachment #265193 - Flags: approval1.8.1.5? → approval1.8.1.5+
Looks like Aaron checked in the branch patch on MOZILLA_1_8_BRANCH 2007-06-29:
accessible/src/msaa/nsAccessibleWrap.cpp  rev. 1.31.4.4
Keywords: fixed1.8.1.5
Is there an end-user testcase to reproduce this, or can we just check talkback/breakpad, to verify?
Crash Signature: [@ msaa/nsAccessibleWrap::NativeAccessible ]
You need to log in before you can comment on or make changes to this bug.