381214 - add admin badge icon to jt batson's spreadfirefox account

Status: RESOLVED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Paul Kim]

JT has an admin badge for SFX but it's not showing up on his posts there. See: http://www.spreadfirefox.com/node/27568 for reference.

The admin badge has been created and is posted here:
http://www.spreadfirefox.com/files/administrators/icons/jtbatson.gif

Comment 1

[Dave Miller [:justdave]]

<img src='http://www.spreadfirefox.com/files/administrators/icons/.gif' align='top'>

The above is the code in the source where the icon is supposed to be.  This tells me something on his account isn't set up right or the template is broken.

Comment 2

[Dave Miller [:justdave]]

question (sort of unrelated) : how come there's no alt="" attribute with the username in it?  Modern html validators will flag an error for img tags without alt attributes (they're considered required these days), and putting the username in it would make the text still readable if the image can't be found and also in text-based browsers like Lynx.

Comment 3

[Asa Dotzler [:asa]]

Dave, because we suck. 

Comment 4

[Dave Miller [:justdave]]

Sorry, I didn't intend for that to sound like I thought anyone sucked. :)  It was only meant to be a suggestion.  I go overboard sometimes.

Comment 5

[Ian Hayward]

Dave, I can picture Asa saying that with a smile on his face ;) I don't think anyone thought you were intending to say that we did. 

But sometimes we do suck, sometimes we use tables when we can't get CSS to work because we don't have enough time to play with it. We should of course have  made  sfx validate ages ago but we are always too busy moving forward with something else! Hurray for sucking only sometimes ;)

Comment 6

[Paul Booker]

I fixed the problem, and requested the change be pushed to production .
https://bugzilla.mozilla.org/show_bug.cgi?id=380044

I guess its me who sucks. (Its all true :-( ) 

Paul

Comment 7

[Paul Booker]

I have fixed the problem with the alt tag which Dave mentioned on the sandbox willow.mozilla.org  but i can't commit the change into cvs after the migration to vm.

The template file that has been modified is /home/paul/spreadfirefox/themes/spreadfirefox/node.tpl.php

Comment 8

[Paul Booker]

You can now push this file to production.

Comment 9

[Paul Booker]

Just a friendly reminder that this ticket needs attention .

Thanks Paul

Comment 10

[Reed Loden [:reed]]

Did you commit the change to CVS? If you did, it would have been picked up in the sync that occurred yesterday. IT does not watch this component at all, so reminders here won't get anything done on IT's side.

Comment 11

[Paul Booker]

Ok , It has been commited and i have confirmed that it looking ok .

Paul