381230 - "Font missing" isn't localizable in Appearance pref pane.

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect, P3)

Description

[Stuart Morgan]

Why does it say to localize it in a comment rather than actually localize it? Who knows.

Comment 1

[Paul Borokhov (lensovet)]

Attachment: One-liner change to Appearance.mm to take localized value

This also requires a change to Localizable.strings, will be uploaded separately since it's a UTF-16 file.

Comment 2

[Paul Borokhov (lensovet)]

Attachment: localizable.strings to go along with patch

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 267928 [details]
localizable.strings to go along with patch

Please simply include the new strings/strings changes in a comment instead of attaching files which can become stale, and then noting the comment that contains the changes in the whiteboard.

And the prefPane should be using its own Localizable.strings file, anyway, rather than calling into the browser's.

Comment 4

[Stuart Morgan]

Comment on attachment 267926 [details] [diff] [review]
One-liner change to Appearance.mm to take localized value

>+      displayString = NSLocalizedString(@"Missingfont", @"Shown in appearance prefpane when the selected font can't be found on the system");

We don't use the comment, so that should be |nil|, and the key should be intercaps (MissingFont)

Comment 5

[Paul Borokhov (lensovet)]

Attachment: revised patch

String needs to be added:
"MissingFont" = "Font missing";

Comment 6

[Paul Borokhov (lensovet)]

Attachment: revised patch, for real this time

apologies for bugspam, correct file attached

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Pulling some prefPane polish bugs to 1.6 as well, per roadmap discussions.

Comment 8

[Stuart Morgan]

Comment on attachment 267935 [details] [diff] [review]
revised patch, for real this time

I wasn't thinking about this being in a pref-pane; it should be using |self getLocalizedString:|

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Paul, can you update this patch to comment 8?

Comment 10

[Stuart Morgan]

Attachment: fix

Comment 11

[Mark Mentovai]

Comment on attachment 277297 [details] [diff] [review]
fix

Don't forget Localizable.strings.

Comment 12

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH (with the Localizable.strings change).