"Font missing" isn't localizable in Appearance pref pane.

RESOLVED FIXED in Camino1.6

Status

Camino Graveyard
Preferences
P3
normal
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Stuart Morgan, Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.8})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.8

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

11 years ago
Why does it say to localize it in a comment rather than actually localize it? Who knows.
Created attachment 267926 [details] [diff] [review]
One-liner change to Appearance.mm to take localized value

This also requires a change to Localizable.strings, will be uploaded separately since it's a UTF-16 file.
Attachment #267926 - Flags: review?(stuart.morgan)
Created attachment 267928 [details]
localizable.strings to go along with patch
Comment on attachment 267928 [details]
localizable.strings to go along with patch

Please simply include the new strings/strings changes in a comment instead of attaching files which can become stale, and then noting the comment that contains the changes in the whiteboard.

And the prefPane should be using its own Localizable.strings file, anyway, rather than calling into the browser's.
Attachment #267928 - Attachment is obsolete: true
(Assignee)

Comment 4

11 years ago
Comment on attachment 267926 [details] [diff] [review]
One-liner change to Appearance.mm to take localized value

>+      displayString = NSLocalizedString(@"Missingfont", @"Shown in appearance prefpane when the selected font can't be found on the system");

We don't use the comment, so that should be |nil|, and the key should be intercaps (MissingFont)
Attachment #267926 - Flags: review?(stuart.morgan) → review-
Created attachment 267934 [details] [diff] [review]
revised patch

String needs to be added:
"MissingFont" = "Font missing";
Attachment #267926 - Attachment is obsolete: true
Attachment #267934 - Flags: review?(stuart.morgan)
Created attachment 267935 [details] [diff] [review]
revised patch, for real this time

apologies for bugspam, correct file attached
Attachment #267934 - Attachment is obsolete: true
Attachment #267935 - Flags: review?(stuart.morgan)
Attachment #267934 - Flags: review?(stuart.morgan)
Whiteboard: new string (Appearance's Localizable.strings) in comment 5
Pulling some prefPane polish bugs to 1.6 as well, per roadmap discussions.
Priority: -- → P3
(Assignee)

Comment 8

11 years ago
Comment on attachment 267935 [details] [diff] [review]
revised patch, for real this time

I wasn't thinking about this being in a pref-pane; it should be using |self getLocalizedString:|
Attachment #267935 - Flags: review?(stuart.morgan) → review-
Paul, can you update this patch to comment 8?
(Assignee)

Comment 10

10 years ago
Created attachment 277297 [details] [diff] [review]
fix
Assignee: nobody → stuart.morgan
Attachment #267935 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #277297 - Flags: superreview?(mark)

Comment 11

10 years ago
Comment on attachment 277297 [details] [diff] [review]
fix

Don't forget Localizable.strings.
Attachment #277297 - Flags: superreview?(mark) → superreview+
(Assignee)

Comment 12

10 years ago
Landed on trunk and MOZILLA_1_8_BRANCH (with the Localizable.strings change).
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: l12y → fixed1.8.1.7
Resolution: --- → FIXED
Whiteboard: new string (Appearance's Localizable.strings) in comment 5
You need to log in before you can comment on or make changes to this bug.