381240 - last-modified-date tests for bookmarks failing on Linux qm-rhel02 dep unit test

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Dietrich Ayala (:dietrich)]

*** CHECK FAILED: false == true
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 114
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_check_true :: line 118
JS frame :: ../../../../_tests/xpcshell-simple/test_places/bookmarks/test_bookmarks.js :: run_test :: line 339
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/tail.js :: <TOP_LEVEL> :: line 41
*** exiting
*** CHECK FAILED: setKeywordForBookmark: 2147500036
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: ../../../../_tests/xpcshell-simple/test_places/bookmarks/test_bookmarks.js :: run_test :: line 341
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/tail.js :: <TOP_LEVEL> :: line 41
2147500036
*** FAIL ***

Comment 1

[Robert Sayre]

These tests pass for me locally on Linux and Mac. On the tinderbox, they pass on Mac, but fail on Linux and Windows.

Comment 2

[Dietrich Ayala (:dietrich)]

(In reply to comment #1)
> These tests pass for me locally on Linux and Mac. On the tinderbox, they pass
> on Mac, but fail on Linux and Windows.
> 

the windows test failure is different than this in the tbox failures. are you getting test failure at the same point in your linux and windows builds?

Comment 3

[Robert Sayre]

(In reply to comment #2)
> (In reply to comment #1)
> > These tests pass for me locally on Linux and Mac. On the tinderbox, they pass
> > on Mac, but fail on Linux and Windows.
> > 
> 
> the windows test failure is different than this in the tbox failures. are you
> getting test failure at the same point in your linux and windows builds?

I tested on Linux and Mac. Haven't tried Windows yet.

Comment 4

[Dietrich Ayala (:dietrich)]

Attachment: backing out last-modified tests for now

r=sayrer over irc

Checking in tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: 1.14; previous revision: 1.13
done

Comment 5

[Dietrich Ayala (:dietrich)]

the lastModified date tests in toolkit are failing. on the linux tinderbox, they failed in 2 different places on different runs, but both are failures of lastModified tests.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: re-enabled tests and added some LOG()s so that we can figure out why it is failing on tinderbox

Comment 7

[(not reading, please use [e-mail] instead)]

after re-enabling the test, here's an example log from a failure (http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1179632280.26650.gz)

*** PLACES TESTS: test setItemTitle
*** PLACES TESTS: dateAdded      = 1179632468976665
*** PLACES TESTS: beforeSetTitle = 1179632468976000
*** PLACES TESTS: lastModified   = 0
*** PLACES TESTS: lastModified2  = 1179632468976418

We are failing because the dateAdded is after lastModified2, but it should be before.

Comment 8

[Dietrich Ayala (:dietrich)]

disabled the tests again, just creating noise in the tinderbox as is.

Checking in tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: 1.23; previous revision: 1.22
done

Comment 9

[(not reading, please use [e-mail] instead)]

disabling more tests:

Checking in bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: 1.24; previous revision: 1.23
done

Comment 10

[(not reading, please use [e-mail] instead)]

disabling more tests:

Checking in test_annotations.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_annotations.js,v  <--
  test_annotations.js
new revision: 1.8; previous revision: 1.7
done

Comment 11

[Dietrich Ayala (:dietrich)]

disabling more tests :)

Checking in test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v  <--  test_bookmarks.js
new revision: 1.25; previous revision: 1.24
done

Comment 12

[Robert Sayre]

(In reply to comment #11)
> disabling more tests 

What is the plan for fixing them? I gather it is a race condition of some sort. Is the API a little too asynchronous? Or is it an obvious mistake that can be easily fixed?

Comment 13

[Dietrich Ayala (:dietrich)]

(In reply to comment #12)
> (In reply to comment #11)
> > disabling more tests 
> 
> What is the plan for fixing them? I gather it is a race condition of some sort.
> Is the API a little too asynchronous? Or is it an obvious mistake that can be
> easily fixed?
> 

not obvious yet, else we'd have fixed it. i'll look at it as soon as possible, but it's not a high priority relative to the other issues that need taking care of before A5 freeze. de-assigning myself for now.

drivers: requesting blocking due to possibly invalid user data on linux.

Comment 14

[Robert Sayre]

(In reply to comment #13)
> 
> not obvious yet, else we'd have fixed it.

I'm sorry, I meant that I understood the fix to be obvious, but possibly time-consuming. I now understand that it is non-obvious and time-consuming.

> i'll look at it as soon as possible,
> but it's not a high priority relative to the other issues that need taking care
> of before A5 freeze.

I don't know what those issues are, so I don't disagree, but see below.

> 
> drivers: requesting blocking due to possibly invalid user data on linux.
> 

There are only three samples, each on different platforms. The bug manifests itself on the linux machine, but it isn't clear that other platforms are unaffected.

Comment 15

[(not reading, please use [e-mail] instead)]

there are a few more tests in test_bookmark.js that we need to turn off (until we figure them out)

from http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1180073941.5712.gz

*** PLACES TESTS: lastModified2 = 1180074217450594
*** exiting
*** CHECK FAILED: false == true
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 114
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/head.js :: do_check_true :: line 118
JS frame :: ../../../../_tests/xpcshell-simple/test_places/bookmarks/test_bookmarks.js :: testSimpleFolderResult :: line 660
JS frame :: ../../../../_tests/xpcshell-simple/test_places/bookmarks/test_bookmarks.js :: run_test :: line 646
JS frame :: /build/slave/trunk_linux/mozilla/tools/test-harness/xpcshell-simple/tail.js :: <TOP_LEVEL> :: line 41
2147500036
*** FAIL ***

give than the test on line 660 fails, there might be others after that in test_bookmarks.js that will also fail intermittely on linux as well.

Comment 16

[(not reading, please use [e-mail] instead)]

disabled more tests (but also added some LOG statements).

cvs ci toolkit/components/places/tests/bookmarks/test_bookmarks.js
Checking in toolkit/components/places/tests/bookmarks/test_bookmarks.js;
/cvsroot/mozilla/toolkit/components/places/tests/bookmarks/test_bookmarks.js,v
<--  test_bookmarks.js
new revision: 1.26; previous revision: 1.25
done

Comment 17

[Dietrich Ayala (:dietrich)]

retargeting bugs that don't meet the alpha release-blocker criteria at http://wiki.mozilla.org/Firefox3/Schedule.

Comment 18

[Mike Connor [:mconnor]]

Not going to continue to block on this.  If you disagree with this decision, please renominate with reasons why we can't ship with this in final

Comment 20

[Dietrich Ayala (:dietrich)]

tests currently disabled due to this bug:

http://mxr.mozilla.org/mozilla-central/search?string=bug%20381240

Comment 21

[Lukas Blakk [:lsblakk] use ?needinfo]

Hope this is the right place - since bug 381351 was marked as a duplicate.

Linux places unit test on 2009/07/08 13:22:04
http://tinderbox.mozilla.org/showlog.cgi?log=Places/1247084524.1247092236.29589.gz


TEST-UNEXPECTED-FAIL | /builds/moz2_slave/places-linux-unittest/build/objdir/_tests/xpcshell/test_places/unit/test_annotations.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/moz2_slave/places-linux-unittest/build/objdir/_tests/xpcshell/test_places/unit/test_annotations.js | 3 == 2 - See following stack:
make: *** [xpcshell-tests] Error 1
Unknown Error: command finished with exit code: 2

Comment 22

[Marco Bonardo [:mak]]

(In reply to comment #21)
> Hope this is the right place - since bug 381351 was marked as a duplicate.

no, the failure you reported is unrelated to this bug, should be filed apart.

Comment 23

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 24

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/ec21b0682874

Comment 25

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7f469bf827b9

Comment 26

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv