Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Allow "moves" as copies for cards to mailing lists

RESOLVED FIXED

Status

MailNews Core
Address Book
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 1 bug, {fixed-seamonkey1.1.3, verified1.8.1.5})

Trunk
fixed-seamonkey1.1.3, verified1.8.1.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 265362 [details] [diff] [review]
Allow "moves" as copies for cards to mailing lists

See the various multiple duplicates filed referenced from bug 349044.

The problem is when I did the drag/drop fix-up I enforced copying to mailing lists, but the default was still move. Unfortunately it appears most users don't know about the ctrl/shift combinations for drag and drop.

Therefore with this patch I'm allowing "moves" to mailing lists to act as copies. canDrop is the only bit that needs to change as onDrop automatically enforces a copy to mailing lists.

I'd still like to have bug 349044 fixed, but I can't see a way to do it in our current implementation. So this bug will fix it so that most users will be able to copy to mailing lists, and bug 349044 will hopefully change the default to copy at some stage.

Note I'm intending to land this on branch once I've been able to confirm it works ok.
Attachment #265362 - Flags: superreview?(bienvenu)
Attachment #265362 - Flags: review?(bienvenu)

Comment 1

10 years ago
Comment on attachment 265362 [details] [diff] [review]
Allow "moves" as copies for cards to mailing lists

this will be a big improvement, thx, mark
Attachment #265362 - Flags: superreview?(bienvenu)
Attachment #265362 - Flags: superreview+
Attachment #265362 - Flags: review?(bienvenu)
Attachment #265362 - Flags: review+
Attachment #265362 - Flags: approval1.8.1.5?
Patch checked into trunk, I'll leave the bug open until we get branch approvals.
Status: NEW → ASSIGNED
Whiteboard: Checked into trunk, waiting branch approval
(In reply to comment #0)
> Created an attachment (id=265362) [details]
...
> Note I'm intending to land this on branch once I've been able to confirm it
> works ok.

btw the patch worked fine on branch as well as trunk.
Marking as fixed, I'll check in to branch once approval is given.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Duplicate of this bug: 383113
Deferring approval to mscott

Updated

10 years ago
Attachment #265362 - Flags: approval1.8.1.5? → approval1.8.1.5+
Keywords: fixed-seamonkey1.1.3, fixed1.8.1.5
Whiteboard: Checked into trunk, waiting branch approval
Looks like there is tree problem in that when I copy the "foo" mailing list from Personal Address Book over to Collected Address Book, although it's populated in the latter, there is no twisty indicating the CAB has content, but clicking on its top-level element shows that it does indeed exist (I'll have to look this separate bug up and file, if necessary).

(I know we've had this bug on the trunk for a while, but I didn't think it affected branch, until now.)

However, the original issue is verified FIXED on "version 2.0.0.5pre (20070711)" using Windows XP SP2.

Replacing fixed1.8.1.5 keyword with verified1.8.1.5
Keywords: fixed1.8.1.5 → verified1.8.1.5
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.