381284 - [FIX]"ASSERTION: reading uninitialized value: 'mUnit != eStyleUnit_Null'"

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: reading uninitialized value: 'mUnit != eStyleUnit_Null', file ../../dist/include/layout/nsStyleCoord.h, line 88

This is hit during reftests (layout/reftests/box-properties/width-special-values-cell-auto.html).

I'm attaching a reduced testcase.

Comment 1

[Boris Zbarsky [:bzbarsky]]

#4  0x1855ba93 in nsStyleCoord::GetUnit (this=0xbfff95fc) at ../../dist/include/layout/nsStyleCoord.h:88
#5  0x1804b49e in GetWidthInfo (aRenderingContext=0x3f3cbfd4, aFrame=0x2448f58, aIsCell=1, aStylePos=0x2449b08) at ../../../mozilla/layout/tables/BasicTableLayoutStrategy.cpp:169

The relevant code is:

161         if (!aIsCell || maxWidth.GetIntValue() == NS_STYLE_WIDTH_FILL)
162             maxWidth.Reset();
...
169     unit = maxWidth.GetUnit();

That Reset() should set to None instead.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 265482 [details] [diff] [review]
Like so

r+sr=dbaron

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.

Comment 5

[Jesse Ruderman]

The testcase here is just one line from (an old version of) the reftest mentioned in comment 0, so this is in-testsuite+.