381298 - startup-with-no-profiles and choosing IE / Opera or Safari doesn't doesn't import favorites / bookmarks

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

Comment 1

[(not reading, please use [e-mail] instead)]

startup-with-no-profiles and choosing IE doesn't doesn't import IE favorites

although manually importing IE favorites works.

additionally, startup-with-no-profiles and Netscape / Seamonkey after we've enable places acts differently that it does in Firefox 2.

Specifically, there is no "Get Bookmarks Add-ons" bookmark, and there is no "Mozilla Firefox" folder.

but, the seamonkey bookmarks are imported, as we copy over the bookmarks.html file, and then on startup, we'll import that into places.

Comment 2

[(not reading, please use [e-mail] instead)]

I think what is going on is that after we copy the favorites, we still blow away all the bookmarks on startup because browser.places.importBookmarksHTML is set to true by default.

I think if we are doing a migration and we call CopyBookmarks() or CopyFavorites() [for IE] with PR_TRUE for aReplace, we need to set browser.places.importBookmarksHTML to false so that on restart, we don't re-import bookmarks.html and blow away what we just migrated.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: we need to fix ie, opera and safari

the other importers copy bookmarks into bookmarks.html, which we will then import.

Comment 4

[(not reading, please use [e-mail] instead)]

the spin off bug to log is restoring the fx 2 behavior of adding the "Get Bookmarks Add-ons" (and other bookmarks, like the "Mozilla Firefox" folder and its bookmarks?) on startup-with-no-profiles import.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 265403 [details] [diff] [review]
we need to fix ie, opera and safari

thanks seth, r=me.

Comment 6

[(not reading, please use [e-mail] instead)]

verifying this on opera will require a fix to bug #381315 first.  

(I locally tested the opera part of my fix by commenting out the code that causes nsINIParser to crash.)

Comment 7

[(not reading, please use [e-mail] instead)]

fixed

Checking in nsIEProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsIEProfileMigrator.cpp,v  <--
  nsIEProfileMigrator.cpp
new revision: 1.57; previous revision: 1.56
done
Checking in nsOperaProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp,v
<--  nsOperaProfileMigrator.cpp
new revision: 1.62; previous revision: 1.61
done
Checking in nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v
 <--  nsSafariProfileMigrator.cpp
new revision: 1.38; previous revision: 1.37
done

Comment 8

[(not reading, please use [e-mail] instead)]

bsmedberg has fixed bug #381315, so it is now possible to verify the fix for opera.

Comment 9

[Carsten Book [:Tomcat]]

Verified fixed for Opera and Internet Explorer with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a5pre) Gecko/20070525 Minefield/3.0a5pre ID:2007052512 [cairo] / no crash on opera and also bookmarks imported with IE 7

Comment 10

[Tracy Walker [:tracy]]

Also verified with safari on Mac build from 2007052505

Comment 11

[(not reading, please use [e-mail] instead)]

> the spin off bug to log is restoring the fx 2 behavior of adding the "Get
> Bookmarks Add-ons" (and other bookmarks, like the "Mozilla Firefox" folder and
> its bookmarks?) on startup-with-no-profiles import.

see bug #38667

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv