Move backspace handling to CHBrowserView

RESOLVED FIXED in Camino1.6

Status

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Tracking

({fixed1.8.1.8})

unspecified
Camino1.6
x86
Mac OS X
fixed1.8.1.8

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
12.54 KB, patch
mikepinkerton
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
Created attachment 265461 [details] [diff] [review]
push backspace handling down

There's no reason for the backspace -> back mapping to be handled all the way up at the BWC layer, since it's really behavior associated with the CHBrowserView. This pushes the mapping and the methods it relies on down into CHBrowserView, and exposes the helpers that are (currently) needed by the spelling logic.
Attachment #265461 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #265461 - Flags: review? → review?(joshmoz)

Updated

11 years ago
Attachment #265461 - Flags: review?(joshmoz) → review+
(Assignee)

Updated

11 years ago
Attachment #265461 - Flags: superreview?(mikepinkerton)
Comment on attachment 265461 [details] [diff] [review]
push backspace handling down

rs=pink but....

isn't this really an application decision? should all embedders need this code if it's a camino thing? just wanted to ask the question...
Attachment #265461 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 2

11 years ago
Comment on attachment 265461 [details] [diff] [review]
push backspace handling down

I'll spin up a new patch with the pref mapping in BW rather than CHBV
Attachment #265461 - Attachment is obsolete: true
(Assignee)

Comment 3

11 years ago
Created attachment 278308 [details] [diff] [review]
v2

Backspace handling is now in BrowserWrapper, rather than CHBrowserView. I left the moved to CHBrowserView since it's Gecko-level stuff.
Attachment #278308 - Flags: superreview?(mikepinkerton)
Comment on attachment 278308 [details] [diff] [review]
v2

sr=pink
Attachment #278308 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 5

11 years ago
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.7
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in before you can comment on or make changes to this bug.