Closed Bug 381375 Opened 17 years ago Closed 17 years ago

ocspclnt doesn't work on Windows

Categories

(NSS :: Tools, defect, P2)

Product:
NSS
Component:
Tools
Version:
3.11.7
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nelson, Assigned: nelson)

Details

Attachments

(1 file)

patch v1
3.11 KB, patch
neil.williams
: review+
julien.pierre
: review+
Details | Diff | Splinter Review
Attached patch patch v1 — — Splinter Review 
ocspclnt has numerous options that read binary input from stdin or
that write binary output to stdout.  They don't work on Windows,
because on windows, stdin and stdout do line end munging unless 
they are put into "binary mode".  

This patch puts them into binary mode on Windows.
It may create warnings on non-Windows platforms.
Attachment #265466 - Flags: superreview?(alexei.volkov.bugs)
Attachment #265466 - Flags: review?(neil.williams)
Assignee: nobody → nelson
Priority: -- → P2
Target Milestone: --- → 3.12
Attachment #265466 - Flags: review?(neil.williams) → review+
Comment on attachment 265466 [details] [diff] [review]
patch v1

seeking second reviewer
Attachment #265466 - Flags: review?(julien.pierre.boogz)
Comment on attachment 265466 [details] [diff] [review]
patch v1

This is OK, except the include of unistd.h in the XP_UNIX block appears to be unnecessary. Please remove it before checkin.
Attachment #265466 - Flags: review?(julien.pierre.boogz) → review+
Attachment #265466 - Flags: superreview?(alexei.volkov.bugs)
Make ocspclnt read and write binary files on stdin and stdout.
bug 381375. r=neil.williams,julien.pierre
Checking in ocspclnt.c;  new revision: 1.10; previous revision: 1.9

Remove #include <unistd.h> for unix.  bug 381375. r=julien.pierre
Checking in ocspclnt.c;  new revision: 1.11; previous revision: 1.10
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: