ocspclnt doesn't work on Windows

RESOLVED FIXED in 3.12

Status

NSS
Tools
P2
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

3.11.7
3.12
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 265466 [details] [diff] [review]
patch v1

ocspclnt has numerous options that read binary input from stdin or
that write binary output to stdout.  They don't work on Windows,
because on windows, stdin and stdout do line end munging unless 
they are put into "binary mode".  

This patch puts them into binary mode on Windows.
It may create warnings on non-Windows platforms.
Attachment #265466 - Flags: superreview?(alexei.volkov.bugs)
Attachment #265466 - Flags: review?(neil.williams)
(Assignee)

Updated

10 years ago
Assignee: nobody → nelson
Priority: -- → P2
Target Milestone: --- → 3.12

Updated

10 years ago
Attachment #265466 - Flags: review?(neil.williams) → review+
(Assignee)

Comment 1

10 years ago
Comment on attachment 265466 [details] [diff] [review]
patch v1

seeking second reviewer
Attachment #265466 - Flags: review?(julien.pierre.boogz)

Comment 2

10 years ago
Comment on attachment 265466 [details] [diff] [review]
patch v1

This is OK, except the include of unistd.h in the XP_UNIX block appears to be unnecessary. Please remove it before checkin.
Attachment #265466 - Flags: review?(julien.pierre.boogz) → review+
(Assignee)

Updated

10 years ago
Attachment #265466 - Flags: superreview?(alexei.volkov.bugs)
(Assignee)

Comment 3

10 years ago
Make ocspclnt read and write binary files on stdin and stdout.
bug 381375. r=neil.williams,julien.pierre
Checking in ocspclnt.c;  new revision: 1.10; previous revision: 1.9

Remove #include <unistd.h> for unix.  bug 381375. r=julien.pierre
Checking in ocspclnt.c;  new revision: 1.11; previous revision: 1.10
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.