Last Comment Bug 381375 - ocspclnt doesn't work on Windows
: ocspclnt doesn't work on Windows
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.11.7
: x86 Windows XP
: P2 normal (vote)
: 3.12
Assigned To: Nelson Bolyard (seldom reads bugmail)
Depends on:
  Show dependency treegraph
Reported: 2007-05-20 17:03 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2007-07-11 16:43 PDT (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch v1 (3.11 KB, patch)
2007-05-20 17:03 PDT, Nelson Bolyard (seldom reads bugmail)
neil.williams: review+
julien.pierre: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2007-05-20 17:03:17 PDT
Created attachment 265466 [details] [diff] [review]
patch v1

ocspclnt has numerous options that read binary input from stdin or
that write binary output to stdout.  They don't work on Windows,
because on windows, stdin and stdout do line end munging unless 
they are put into "binary mode".  

This patch puts them into binary mode on Windows.
It may create warnings on non-Windows platforms.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2007-07-10 11:41:00 PDT
Comment on attachment 265466 [details] [diff] [review]
patch v1

seeking second reviewer
Comment 2 Julien Pierre 2007-07-10 14:47:56 PDT
Comment on attachment 265466 [details] [diff] [review]
patch v1

This is OK, except the include of unistd.h in the XP_UNIX block appears to be unnecessary. Please remove it before checkin.
Comment 3 Nelson Bolyard (seldom reads bugmail) 2007-07-11 16:43:42 PDT
Make ocspclnt read and write binary files on stdin and stdout.
bug 381375. r=neil.williams,julien.pierre
Checking in ocspclnt.c;  new revision: 1.10; previous revision: 1.9

Remove #include <unistd.h> for unix.  bug 381375. r=julien.pierre
Checking in ocspclnt.c;  new revision: 1.11; previous revision: 1.10

Note You need to log in before you can comment on or make changes to this bug.