381404 - nsFocusController::MoveFocus() should indicate failure

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Daniel Bainton]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20070310 Iceweasel/2.0.0.3 (Debian-2.0.0.3-1)
Build Identifier: trunk

I'm using the Focus Controller and I want some way of telling if MoveFocus fails.

Reproducible: Didn't try

Steps to Reproduce:
1. Call nsFocusController::MoveFocus() with a DOM node that isn't currently in the document
There are other ways for this to happen...
Actual Results:  
Method returns NS_OK and nothing happens.

Expected Results:  
Some indication that it failed.

Comment 1

[Daniel Bainton]

Attachment: nsFocusController::MoveFocus() return failure for error case

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 265495 [details] [diff] [review]
nsFocusController::MoveFocus() return failure for error case

The change looks ok to me, but if we're doing this I think
we should also remove the GetNumberOfShells block that follows -
it's redundant, GetPrimaryShell() will return nsnull in that
case, and if that happens I think we should fail there too and
at the end return the result of the ShiftFocus() call instead
of NS_OK. Please post an updated patch with those changes.

Comment 3

[Daniel Bainton]

Attachment: nsFocusController::MoveFocus() return failure for error case (updated)

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 265505 [details] [diff] [review]
nsFocusController::MoveFocus() return failure for error case (updated)

r=mats

Comment 5

[Mats Palmgren (inactive)]

Checked in to trunk at 2007-06-18 17:49 PDT.

-> FIXED