If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Mac] Rename "Get Info" back to "Properties"

VERIFIED FIXED

Status

()

Firefox
Bookmarks & History
--
trivial
VERIFIED FIXED
11 years ago
8 years ago

People

(Reporter: Jesse Ruderman, Assigned: Joey Minta)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.11 KB, patch
mano
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
The Places landing changed the menu item "Properties" to "Get Info" on Mac.

I use it for renaming bookmarks (on the bookmarks toolbar) much more often than I use it for anything else, so having it named "Get Info" is strange.  "Get Info" makes sense for files in Finder, where most of the controls are read-only and the modifiable controls are rarely used, but it doesn't make sense for bookmarks.
(Assignee)

Comment 1

11 years ago
Created attachment 265546 [details] [diff] [review]
patch

The mac ifdef has been there since rev. 1.1, so I'm not sure of the original motivation behind it.  That said, here's a patch to makes all platforms use "Properties."
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #265546 - Flags: review?(mano)
Comment on attachment 265546 [details] [diff] [review]
patch

This breaks the organizer window.
Attachment #265546 - Flags: review?(mano) → review-
(Assignee)

Comment 3

11 years ago
Created attachment 265584 [details] [diff] [review]
patch v2

Better patch this time.  Gets all the uses of the entities.
Attachment #265546 - Attachment is obsolete: true
Attachment #265584 - Flags: review?(mano)
Comment on attachment 265584 [details] [diff] [review]
patch v2

r=mano.
Attachment #265584 - Flags: review?(mano) → review+
(Assignee)

Comment 5

11 years ago
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.74; previous revision: 1.73
done
Checking in browser/components/places/content/placesOverlay.xul;
/cvsroot/mozilla/browser/components/places/content/placesOverlay.xul,v  <--  placesOverlay.xul
new revision: 1.11; previous revision: 1.10
done
Checking in browser/locales/en-US/chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--  places.dtd
new revision: 1.23; previous revision: 1.22
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 6

11 years ago
> -<!ENTITY cmd.show_infoWin.accesskey
> +<!ENTITY cmd.properties.accesskey
>    "i">

"P" ???
(Assignee)

Comment 7

11 years ago
P is used for "Paste" already
http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/chrome/browser/places/places.dtd#91

Comment 8

11 years ago
(In reply to comment #6)
> > -<!ENTITY cmd.show_infoWin.accesskey
> > +<!ENTITY cmd.properties.accesskey
> >    "i">
> 
> "P" ???

Sorry for bugspam - that is Paste. On Firefox 2 "r".

Comment 9

10 years ago
verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.