381545 - "Find Updates" button is not clickable on 100% of its surface

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Constantine Dokolas]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3

The "Find Updates" button for add-ons and themes is not clickable on a thin strip at its bottom.

Reproducible: Always

Steps to Reproduce:
1. Click Tools->Add-ons
2. Place mouse cursor within the bottom 4-5 pixels
3. Click
Actual Results:  
The button does not react


Windows 2000 (sp4) with NVidia GeForce 4400 MX (driver v.93.71) screen resolution 1152x864x32@75Hz, default dpi and colors (default theme).

My only reason for entering this bug is the possibility of the form having a problem, or (worse) the UI engine (called XUL, if I remember correctly) having a problem.

The exact same problem exists with Thunderbird. I haven't found the same type of button elsewhere in both applications to test (i.e. non-toolbar button with embedded icon).

I'm NOT going to file this bug for Thunderbird also. I'll leave that to the Mozilla people.

Comment 1

[Brian Polidoro]

Confirmed with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070522 Minefield/3.0a5pre ID:2007052204 [cairo]

Also you can see the unclickable area because the hover effect is removed too.  I don't see this at the only other place I know of a similar button.  Which that is the clean up button on the download manager.  

Also Nightly tester tools adds a button to the addon manager which also shows the problem.  

Comment 2

[Constantine Dokolas]

I suspect that the status bar at the bottom of the window is on top of the other controls. The status bar is there only because of the resizing "tab" feature at the corner but, although the rest of it is transparent, it is none the less on top of the buttons at the bottom. The status bar needs to be behind the other controls.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

the negative margin causes this bug

Comment 4

[Asaf Romano (gone)]

Comment on attachment 287192 [details] [diff] [review]
patch

r=mano

Comment 5

[Reed Loden [:reed]]

Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.32; previous revision: 1.31
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.36; previous revision: 1.35
done

Comment 6

[Alfred Kayser]

A better solution would be to combine the commandBarBottom and resizerBox into one box:
replacing:
   <vbox>
216     <hbox id="commandBarBottom" align="center">
217       <button id="installFileButton" label="&cmd.installLocalFile.label;"
           ....
258     </hbox>
259     <hbox id="resizerBox" style="min-width:1px;">
260       <spacer flex="1"/>
261       <resizer dir="bottomright"/>

with:
   <vbox>
216     <hbox id="bottomBar" align="center">
217       <button id="installFileButton" label="&cmd.installLocalFile.label;"
           ....
260       <spacer flex="1"/>
261       <resizer dir="bottomright"/>

Instead of playing with negative margins...

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #6)
That's what I thought as well when I did this initially but it caused other problems that I don't recall atm. It was an ugly hack to get around the problem before the 2.0 release.

Comment 8

[Kevin Brosnan]

v. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre ID:2007112704

Comment 9

[Constantine Dokolas]

Great job guys (and gals, if any)!