381596 - Macroize simple SVG DOM getters

Status: RESOLVED WONTFIX

(Core :: SVG, defect)

Description

[tor]

Attachment: add and use macros for svg getters

Comment 1

[Jonathan Watt [:jwatt]]

I've been wavering over this one to be honest. The patch reduces file size some, but in areas that aren't very complex. Personally I think it's just about as easy to scroll past these areas as the macro calls. On the down side the macro indirection makes LXR searches less useful and may mean searches for members miss important parts of code. I'm not really sure it's worth it, but what the heck, r=jwatt. Please reverse the order of the first two arguments to put the class name first though.

Comment 2

[tor]

roc, do you have an opinion about the usefulness of replacing frequent code snippets with macros?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm torn as well. Why don't you post on .platform or something? We don't do this kind of thing elsewhere, except in a few places.

Comment 4

[Robert Longson [:longsonr]]

These are basically one line now anyway.