381685 - Clean up status and separator interface on Bookmark

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Stuart Morgan]

Attachment: clean up

The Bookmark class has a bunch of messiness left over from the old automatic bookmark checking and the shoe-horning-in of separator as a status field. This is an incremental patch to substantially improve things. There is a lot left to do to improve things here, and I'll follow up with more later on, but I want to keep the change easy to review.

- creates a new utility method for clients to use to create separators
- removes status and setStatus:, since they are no longer meaningful, as well as the status parameter of a bookmark-adding method (the value it always used is already the default)
- makes setIsSeparator: private, since no-one should ever change a bookmark after it's created (removing this entirely requires more surgery that I'll do later)
- makes the safe-accessors that are only needed internally private (again, savedStatus will be removed later)

Comment 1

[Stuart Morgan]

I forgot:
- pushes the remnant of status into the bookmark reading/writing (eliminating is later), so the internal class state no longer has the status concept.

(This may need bug 380586's patch applied to compile/run correctly; I didn't want to mess with code we are removing)

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 265766 [details] [diff] [review]
clean up

+      [self setTitle:NSLocalizedString(@"<Menu Spacer>", nil)];

why is this localized? Is it ever shown to the user?

sr=pink

Comment 3

[Stuart Morgan]

Yes, unfortunately. It's one of those things that we really need to fix about the way the bookmark inspector panel works.

Comment 4

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH