381689 - The submenu still opens when I use 'Properties' for a folder on the submenu of bookmark toolbar

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

1. Open a sub folder[1] on bookmark toolbar which has sub folder[2].
2. Reight-click the sub folder[2] on the sub folder[1] of bookmark toolbar.
3. Execute 'Properties'.

The sub menu for sub folder[2] is still opened. It may be over the dialog.

The places menus for folders and the context menu for them are in different context (i.e., they are not in a menu chain). Therefore, mMenuParent->HideChain() of nsMenuFrame::Execute cannot close the places menus. I think that this is a layout/xul bug.

I think that nsMenuDismissalListener should have |HideChain()| which can close all menus of all contexts. And it should be called from nsMenuFrame::Execute (and similar points).

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

maybe, this will be fixed by bug 279703.

Comment 2

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

This appears to be fixed by bug 279703. When I right-click a sub-folder of a folder on the bookmarks toolbar and select Properties, the properties window appears and the expanded menu coming off the bookmarks toolbar is gone.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

-> v.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv