381839 - typos, misalignments, etc. (May 2007 edition)

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Simon Bünzli]

Comment 1

[Simon Bünzli]

Attachment: patch

Comment 2

[Michael Wu [:mwu]]

   // minimal interval between two save operations (in milliseconds)
-  _interval: 1000,
+  _interval: 10000,

Hmm.. why? Doesn't seem to be a minor change..

Comment 3

[Simon Bünzli]

Really, it's just a typo. The default pref value is 10000 (see http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/app/profile/firefox.js&rev=1.185&mark=530-531#526 ) and at startup we read it from there, overriding that pseudo-default (see http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/sessionstore/src/nsSessionStore.js&rev=1.64&mark=174-175#150 ). That value of 1000 never had any consequences, neither will a value of 10000 - it just reflects the actual default.

Comment 4

[Shawn Wilsher :sdwilsh]

it probably doesn't need it - but do you mind getting review so people feel better about checking it in please?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 265919 [details] [diff] [review]
patch

r=me, though I think it's generally better to just omit the "pseudo defaults".

Comment 6

[Shawn Wilsher :sdwilsh]

ok, how about an updated patch that applies cleanly (or even semi-cleanly) please?

Comment 7

[Simon Bünzli]

Attachment: unbitrotted patch for check-in

(In reply to comment #5)
> I think it's generally better to just omit the "pseudo defaults".

And then just assign and use in the code, effectively dropping the "field declaration" at the top of the object? Keeping those around might make it easier to understand which properties are used for what. What to assign them is a certain issue though... anyway, if you wish to change that, please file a bug and I'll get you a patch to review.

Comment 8

[Michael Wu [:mwu]]

Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.69; previous revision: 1.68
done