382015 - Handle old/new API behavior of cairo_{fill,stroke}_extent on branch

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Attachment: don't depend on API bug

Since linux distributors can't seem to understand "--enable-system-cairo is unsupported", we need to change the branch SVG code to handle both the old and new API behavior of cairo_{fill,stroke}_extent.

Comment 1

[Sylvain Pasche]

I can confirm this fixes the issue mentioned on https://bugs.launchpad.net/fedora/+source/firefox/+bug/99368 or https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232796

Comment 2

[Jonathan Watt [:jwatt]]

What is the API bug that we don't want to depend on?

Comment 3

[Sylvain Pasche]

Here's the commit Tim found that fixes the API bug in question: http://gitweb.freedesktop.org/?p=cairo.git;a=commitdiff;h=a8ca155f83098c02fb8d3acc57b0492d5b753d54

"Correctly return the transformed bounding box for stroke/fill extents,
instead of just transforming the two corners separately."

Comment 4

[Jonathan Watt [:jwatt]]

Thanks Sylvain.

Comment 5

[tor]

Comment on attachment 266077 [details] [diff] [review]
don't depend on API bug

Linux distributors have been ignoring our advice that --enable-system-cairo is unsupported and are running Firefox against newer versions of cairo than what's in the tree.  The branch svg code relied on a bug in one of the cairo APIs that has since been fixed.  This patch moves similar fixes that were made to the trunk about half a year ago, and makes the code work with both old and new behavior.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 266077 [details] [diff] [review]
don't depend on API bug

approved for 1.8.1.5, a=dveditz for release-drivers

Comment 7

[tor]

Checked in on MOZILLA_1_8_BRANCH.