Handle old/new API behavior of cairo_{fill,stroke}_extent on branch

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: tor, Unassigned)

Tracking

({fixed1.8.1.5})

1.8 Branch
x86
Linux
fixed1.8.1.5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 266077 [details] [diff] [review]
don't depend on API bug

Since linux distributors can't seem to understand "--enable-system-cairo is unsupported", we need to change the branch SVG code to handle both the old and new API behavior of cairo_{fill,stroke}_extent.

Comment 1

10 years ago
I can confirm this fixes the issue mentioned on https://bugs.launchpad.net/fedora/+source/firefox/+bug/99368 or https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232796
(Reporter)

Updated

10 years ago
Attachment #266077 - Flags: review?(jwatt)
What is the API bug that we don't want to depend on?

Comment 3

10 years ago
Here's the commit Tim found that fixes the API bug in question: http://gitweb.freedesktop.org/?p=cairo.git;a=commitdiff;h=a8ca155f83098c02fb8d3acc57b0492d5b753d54

"Correctly return the transformed bounding box for stroke/fill extents,
instead of just transforming the two corners separately."
Thanks Sylvain.

Updated

10 years ago
Attachment #266077 - Flags: review?(jwatt) → review+
(Reporter)

Updated

10 years ago
Attachment #266077 - Flags: superreview?(roc)
Attachment #266077 - Flags: superreview?(roc) → superreview+
(Reporter)

Comment 5

10 years ago
Comment on attachment 266077 [details] [diff] [review]
don't depend on API bug

Linux distributors have been ignoring our advice that --enable-system-cairo is unsupported and are running Firefox against newer versions of cairo than what's in the tree.  The branch svg code relied on a bug in one of the cairo APIs that has since been fixed.  This patch moves similar fixes that were made to the trunk about half a year ago, and makes the code work with both old and new behavior.
Attachment #266077 - Flags: approval1.8.1.5?
Comment on attachment 266077 [details] [diff] [review]
don't depend on API bug

approved for 1.8.1.5, a=dveditz for release-drivers
Attachment #266077 - Flags: approval1.8.1.5? → approval1.8.1.5+
(Reporter)

Comment 7

10 years ago
Checked in on MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Keywords: fixed1.8.1.5

Updated

7 years ago
You need to log in before you can comment on or make changes to this bug.