382081 - Small downloads don't show in download manager when already open

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Michael Wu [:mwu]]

If a new download is started with the download manager open, it doesn't always show up in the download manager.

To reproduce:
1. open downloads manager
2. clear existing downloads
3. attempt to download a small file

The new download doesn't show in the downloads manager.

Comment 1

[Shawn Wilsher :sdwilsh]

I'm pretty sure I know how to fix it.  This is all because we cannot use templates :(

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Basically, the template took care of this before.  Small files complete before the update interval, so they never got flagged as started.  Part of this is because I moved the dl-start notification there, but it needs to stay there.  The best part is that the unit tests verify that this doesn't break anything ;)

Anyway, this is one additional check each time this function is called, but it's just comparing too PRInt16s, so it's quick.  Too bad we have to do it though :(

Comment 3

[Shawn Wilsher :sdwilsh]

Regardless of this working with or without the templates, it's still a bug.  I probably should add a test case as well.

Comment 4

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.84; previous revision: 1.83

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4520

in-litmus+

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007081705 Minefield/3.0a8pre